Repository navigation
Build the strip.py output in CI - #8
Draft
Stuartwastaken wants to merge 1 commit into
Draft
Stuartwastaken wants to merge 1 commit into
Stuartwastaken wants to merge 1 commit into
Conversation
__STRIP__=1 strips with the preprocessor, so nothing compiled what util/strip.py writes, and mistakes like the dangling else fixed in dc2f395 went unnoticed. strip.py --kernel keeps the code for a given Linux version in LINUX_VERSION_CODE blocks, so the output builds with the CI kernel.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
__STRIP__=1strips with the preprocessor, so nothing in CI compiles what util/strip.py actually writes for upstreaming. This adds a step that runsmake net-nextinto a temp dir and builds the result against the same 6.17.8 tree with -Werror. To make that possible,strip.py --kernel X.Y.Zkeeps the code for that Linux version inLINUX_VERSION_CODEblocks instead of always the#else; without the option the output is unchanged.It needs the strip.py fix in the base branch: without it, this step fails on main today with
redefinition of 'homa_tx_pool_mem_nid'. With the PlatformLab#126 strip.py fix (dc2f395) reverted, it fails withhoma_timer.c:106: suggest explicit braces to avoid ambiguous 'else'(https://github.com/Stuartwastaken/HomaModule/actions/runs/40747769139).