Parse filenames in Swift instead of Perl - #142
Open
mmayer wants to merge 2 commits into
Open
Conversation
The tests compare the output of the Swift parser to what the Perl parser used to generate.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Hi Damiano,
Not sure if you are interested in this. I had some fun over the weekend pointing Cursor at the Subler sources and asking it to port the Perl parsing script to Swift native code – and it did. Quite quickly, in fact.
It even wrote some unit tests to verify that the Swift parser does what the Perl parser used to do. In my trials, it has been working fine, as well.
The changes do not remove the Perl code from the repo, but it is no longer being installed as a resource under Subler.app.
Regards,
-Markus