Keep spellchecking local and run lint in CI

[Walentalien]

No description provided.

[Walentalien]

@drbruced12
Ubuntu uses 2020 version of dictionary and spellcheck fails on words that are added in newer version (that Arch pins for example)

The solution is either to add those words to dict.txt OR use arch container in ci (can also install latest dictionary with a script but it's not best solution)
I'd just use Arch container.

Do you care about spellchecker in ci at all ?

[llpeterson]

I'm not anxious to complicate our CI process. It's great that contributors can spell check their contributions (and I'm happy to have it working again for myself), but automatically including it in the pipeline isn't a requirement.

[Walentalien]

I'm not anxious to complicate our CI process. It's great that contributors can spell check their contributions (and I'm happy to have it working again for myself), but automatically including it in the pipeline isn't a requirement.

That makes sense. CI was already running spelling check through make test, but it wasn't failing the job. I've changed CI to run lint and build (running spellcheck is for local usage now)

[drbruced12]

Thanks for explaining the dictionary issue - I was a bit mystified by the failure of "dahl". I think we are all on the same page now so going ahead with merge.