Repository navigation
Add Android TV side-panel menus - #126
Open
MattiasBuelens wants to merge 6 commits into
Open
MattiasBuelens wants to merge 6 commits into
MattiasBuelens wants to merge 6 commits into
Conversation
Contributor
|
I'll fix CI failures and address comments from users with write access. I'll skip comments containing "(aside)".
|
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
devin-ai-integration
Bot
force-pushed
the
feature/tv-menus
branch
from
October 15, 2026 11:09
5d5958d to
95cefda
Compare
MattiasBuelens
added this pull request to stack #123
October 15, 2026 11:10
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
Co-Authored-By: Devin AI <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Adds the language and settings menus to
android-ui-tv. They open as an M3 modal side sheet on the end edge of the player, styled after YouTube's Android TV player. Names andstateoverloads mirror the mobile menus (all@ExperimentalTvUiApi):theo_ui_container. It slides in from the end edge when opened from the controls; switching between menus crossfades.ListItemcard (surfaceVariant, 8 dp apart). Submenu rows have a leading icon and a trailing›. The selected list item has a trailing check. When a list opens, it scrolls to and focuses the selected item (focusRestorer(selectedRequester)). Picking an item closes that submenu, the same as mobile.LanguageMenuonly shows the compact rows. There's no expanded side-by-side form, since the panel is narrow.:ui-commonas@InternalUiApiso both modules can use them:formatTrackName(backing:ui's publicformatTrackLabel),formatPlaybackRate,formatBandwidth,formatActiveQualityLabel,defaultPlaybackRates, and theutil/track-label helpers. No public API changes in:ui.The Robolectric tests drive the menus with D-pad keys, because tv-material components don't react to touch clicks. They cover button visibility, focus on open, track/quality/rate selection, and Back from a submenu, then from the menu, back to the controls.
Link to Devin session: https://dolby.devinenterprise.com/sessions/0a6e1645d4f141408a29401d199e8716
Open in Devin Desktop: https://dolby.devinenterprise.com/desktop/session/0a6e1645d4f141408a29401d199e8716?variant=devin
Requested by: @MattiasBuelens