Repository navigation
fix(comscore): cap android-analytics below 6.16.0 - #491
Merged
Merged
Conversation
comscore 6.16.0 declares minCompileSdk=37, which the current AGP line (8.13.x, max recommended compileSdk 36) cannot satisfy, breaking every Android build once the floating "6.+" dependency resolves to it. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
🦋 Changeset detectedLatest commit: ab33792 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
bob runs the commonjs/module/typescript targets concurrently, and the typescript target's tsc glob could pick up .js files under lib/ mid-write (allowJs is inherited), failing builds with TS6053 "File not found". Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
comscore/android/build.gradleresolvescom.comscore:android-analyticsvia floating6.+. Newly published 6.16.0 shipsminCompileSdk=37in its AAR metadata, so every Android build againstcompileSdk 36now fails:app:checkReleaseAarMetadata— currently breaking the open Dependabot PRs (chore(deps): bump compression from 1.8.1 to 1.8.2 in /apps/engage-example #489, chore(deps): bump shell-quote from 1.10.0 to 1.12.0 in /apps/e2e #490) and any new Android PR build.6.15.+(latest line compatible with AGP 8.13's max recommended compileSdk 36). Consumers targeting a newer compileSdk can still override viaTHEOplayerComscore_comscoreVersion.android-analytics-6.15.0.aar→minCompileSdk=1;6.16.0→minCompileSdk=37.Test plan
@dependabot rebaseon chore(deps): bump compression from 1.8.1 to 1.8.2 in /apps/engage-example #489 and chore(deps): bump shell-quote from 1.10.0 to 1.12.0 in /apps/e2e #490.Generated with Devin
Update — second failure found
First run also exposed a latent flake:
bobruns commonjs/module/typescript targets concurrently, andtsc's**/*program glob (with inheritedallowJs) can catchlib/**/*.jsoutputs mid-write →TS6053(nielsen build). All*/tsconfig.build.jsonnow excludenode_modulesandlib.