Repository navigation
Expose additional THEOlive endpoint properties on Android and iOS - #929
Open
tvanlaerhoven wants to merge 2 commits into
Open
tvanlaerhoven wants to merge 2 commits into
tvanlaerhoven wants to merge 2 commits into
Conversation
Extend the endpoint payload of the `endpointloaded` event so the bridge surfaces everything the native SDKs offer: - Android: `provider` and `adSystem` are now forwarded (guarded for SDKs that predate these getters), and `millicastSrc` now includes its `webrtc` playout delay options. - Android & iOS: the generic `src`/`srcType` properties that the web SDK reports are now derived from the resolved source field (`hesp`, `hls`, `hlsMpegTs`, `millicast` or `dai`), closing the platform gap in the `TheoLiveEndpoint` type. `provider`/`adSystem` are not exposed by the iOS THEOlive integration SDK (verified up to 11.12.1), so they remain web/Android-only. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
Comment on lines
+95
to
+115
| when { | ||
| endPoint.hespSrc != null -> { | ||
| putString(PROP_SRC_TYPE, SRC_TYPE_HESP) | ||
| putString(PROP_SRC, endPoint.hespSrc) | ||
| } | ||
| endPoint.hlsSrc != null -> { | ||
| putString(PROP_SRC_TYPE, SRC_TYPE_HLS) | ||
| putString(PROP_SRC, endPoint.hlsSrc) | ||
| } | ||
| endPoint.hlsMpegTsSrc != null -> { | ||
| putString(PROP_SRC_TYPE, SRC_TYPE_HLS_MPEG_TS) | ||
| putString(PROP_SRC, endPoint.hlsMpegTsSrc) | ||
| } | ||
| endPoint.millicastSrc != null -> { | ||
| putString(PROP_SRC_TYPE, SRC_TYPE_MILLICAST) | ||
| endPoint.millicastSrc?.let { putMap(PROP_SRC, fromEndPointMillicastSource(it)) } | ||
| } | ||
| endPoint.daiAssetKey != null -> { | ||
| putString(PROP_SRC_TYPE, SRC_TYPE_DAI) | ||
| putString(PROP_SRC, endPoint.daiAssetKey) | ||
| } |
Contributor
There was a problem hiding this comment.
🔍 Confirm source selection for multi-source endpoints
When an endpoint has multiple populated source fields, srcType follows a fixed priority rather than the playback-selected source. Confirm the native SDK guarantees only one populated field, or use its selected-source signal.
Was this helpful? React with 👍 or 👎 to provide feedback.
|
|
||
| ### Added | ||
|
|
||
| - Added `src` and `srcType` properties to the THEOlive `endpoint` object on the `endpointloaded` event on Android and iOS, and `provider` and `adSystem` on Android. Also added the `webrtc` playout delay options to `millicastSrc` on Android. |
Contributor
There was a problem hiding this comment.
🔍 Split the two-sentence changelog entry
The Added entry covers endpoint properties and WebRTC options in two sentences. Project rules require one sentence per changelog entry.
Was this helpful? React with 👍 or 👎 to provide feedback.
comscore android-analytics 6.16.0 requires compileSdk 37, which the e2e app cannot satisfy (AGP 8.13.0 supports up to 36). The connector default '6.+' range silently upgraded to it, breaking the Android E2E build.
This branch has not been deployed
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Extends the
endpointpayload of the THEOliveendpointloadedevent so the bridge surfaces every property the native SDKs expose, matching the web SDK'sEndpointshape as closely as possible:providerandadSystemfromEndpoint(accessed defensively, as these getters do not exist on older Android SDK versions that the library still supports);millicastSrcnow also includes itswebrtcplayout delay options.src/srcTypeproperties the web SDK reports are derived from the resolved source field (hesp,hls,hlsMpegTs,millicastordai), since neither nativeEndpointtype carries them.TheoLiveEndpointplatform annotations updated accordingly; newadSystemmember is Android-only.Remaining gaps
provider/adSystemon iOS:EndpointAPIinTHEOplayer-Integration-THEOlive(verified on 11.12.1) does not expose either property — requires a core iOS SDK addition before the bridge can forward it.distributionremains web-only; the nativeEndpointtypes do not carry it (it is delivered viadistributionloadedinstead).Test plan
npm run typescript -- --project tsconfig.build.jsonnpm run lintendpointloadedpayload on Android and iOS example apps against a THEOlive channelGenerated with Devin