Repository navigation
Bridge liveOffset player configuration on Android - #930
Closed
tvanlaerhoven wants to merge 1 commit into
Closed
tvanlaerhoven wants to merge 1 commit into
tvanlaerhoven wants to merge 1 commit into
Conversation
The liveOffset property in PlayerConfiguration was only bridged at the source level on Android. Since the native SDK no longer exposes it on THEOplayerConfig.Builder, apply it as the default live offset for sources that do not specify their own. Also clean up PlayerConfigAdapter: shared nullable accessors for ReadableMap, single lookup of nested ads/ima configuration, and fix sessionID reading the ppid value instead. Generated with [Devin](https://devin.ai) Co-Authored-By: Devin <158243242+devin-ai-integration[bot]@users.noreply.github.com>
![devin-ai-integration[bot]](https://avatars.githubusercontent.com/in/811515?s=60&v=4){kind=small}
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
liveOffsetproperty fromPlayerConfigurationon Android. The nativeTHEOplayerConfig.Builderno longer exposes it, so it is applied viaSourceAdapteras the default live offset for sources that do not specify their ownliveOffset.PlayerConfigAdapter: shared nullableReadableMapaccessors, single lookup of nestedads/imaconfiguration, and unconditional IMA partnerplayerType/playerVersion.ads.ima.sessionIDbeing ignored on Android (it read theppidvalue instead).Test plan
:react-native-theoplayer:compileDebugKotlinpasses ine2e/android:react-native-theoplayer:testDebugUnitTestpassesliveOffsetis set inPlayerConfigurationGenerated with Devin