fix(editor): handle qualified tables in grid editing - #660
Open
debba wants to merge 2 commits into
Open
Conversation
2 tasks
debba
force-pushed
the
fix/issue-659-qualified-grid-tables
branch
from
August 18, 2026 19:16
8edfaa9 to
e99be83
Compare
Contributor
Code Review SummaryStatus: No Issues Found | Recommendation: Merge Files Reviewed (7 files)
Reviewed by glm-5.2 · Input: 40.1K · Output: 12.6K · Cached: 260.5K |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix grid editing and autocomplete for queries that qualify a table with the active schema or database, such as:
The table extractor previously treated
Opsas the table name, so primary key lookup failed and the grid reported thatOpshad no primary key.The extractor now resolves
AddresseswhenOpsmatches the active database. A mismatched qualifier remains non-editable to prevent writes from targeting a table with the same name in the wrong database.Autocomplete now keeps the database associated with each loaded table. Typing
Ops.in a table position suggests tables fromOps, whileOps.Addresses.and table aliases continue to suggest columns.Testing
Ops.Addresseson MySQL 8.4Closes #659