Skip to content

Update apps for SDK changes - #40

Merged
KenVanHoeylandt merged 3 commits into
mainfrom
develop
Aug 20, 2026
Merged

Update apps for SDK changes#40
KenVanHoeylandt merged 3 commits into
mainfrom
develop

Conversation

@KenVanHoeylandt

@KenVanHoeylandt KenVanHoeylandt commented Aug 20, 2026

Copy link
Copy Markdown
Contributor

Summary by CodeRabbit

  • New Features

    • Calculator now reports errors for invalid expressions, unmatched parentheses, insufficient operands, division by zero, and incomplete results while preserving the entered formula.
    • Improved app-specific data storage and dialog launching across supported applications.
  • Updates

    • Refreshed identifiers and incremented versions for Brainfuck, Breakout, Calculator, Diceware, Epub Reader, GPIO, Snake, Serial Console, TamaTac, Todo List, and other included apps.
  • Maintenance

    • Simplified the shared C++ library by removing obsolete application, preferences, UART, and display-lock interfaces.

@coderabbitai

coderabbitai Bot commented Aug 20, 2026

Copy link
Copy Markdown

Review Change Stack

Warning

Review limit reached

@KenVanHoeylandt, you've reached your PR review limit, so we couldn't start this review.

Next review available in: 5 minutes

Limit details: You’ve used the included review currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

How can I continue?

Wait for the limit to reset, then comment @coderabbitai review or push new commits to the PR.

An organization admin can change what happens after included review limits in Billing.

How do review limits work?

CodeRabbit enforces per-developer PR review limits within each organization.

For paid Pro and Pro+ reviews, CodeRabbit uses a developer's included PR review attempts over the past 7 days to set the current hourly allowance. At typical activity levels, the full plan allowance applies. Higher sustained activity can lower the allowance until earlier attempts leave the 7-day window.

Please refer docs for additional details.

Review details
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: d859d63e-caff-4b95-8087-1c7fa4940f9e

📥 Commits

Reviewing files that changed from the base of the PR and between f5999b9 and 1a5ba19.

📒 Files selected for processing (3)
  • Apps/Calculator/main/Source/Calculator.cpp
  • Apps/Calculator/main/Source/Calculator.h
  • Apps/TwoEleven/main/Source/TwoEleven.cpp
📝 Walkthrough

Walkthrough

The changes update application manifests to use tactility.* identifiers and newer versions. Several applications now use app_paths_get_user_data_path for preference files and namespaced identifiers for dialog launches. Calculator parsing and evaluation now report failures and display "Error" for invalid formulas. The TactilityCpp App, LvglLock, Preferences, and Uart headers, README, and license text were removed.

🚥 Pre-merge checks | ✅ 4 | ❌ 1

❌ Failed checks (1 warning)

Check name Status Explanation Resolution
Docstring Coverage ⚠️ Warning Docstring coverage is 14.29% which is insufficient. The required threshold is 80.00%. Write docstrings for the functions missing them to satisfy the coverage threshold.
✅ Passed checks (4 passed)
Check name Status Explanation
Description Check ✅ Passed Check skipped - CodeRabbit’s high-level summary is enabled.
Title check ✅ Passed The title clearly summarizes the main changes, which update apps for SDK API changes and related metadata updates.
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches 💡 1
📝 Generate docstrings 💡
  • Create stacked PR
  • Commit on current branch
🧪 Generate unit tests (beta)
  • Create PR with unit tests
  • Commit unit tests in branch develop

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@coderabbitai coderabbitai Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 6


ℹ️ Review info
⚙️ Run configuration

Configuration used: Organization UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 6e15dd77-1bd0-4378-ac46-2bb24da93bba

📥 Commits

Reviewing files that changed from the base of the PR and between 2f5b2dc and f5999b9.

📒 Files selected for processing (32)
  • Apps/Brainfuck/manifest.properties
  • Apps/Breakout/manifest.properties
  • Apps/Calculator/main/Source/Calculator.cpp
  • Apps/Calculator/manifest.properties
  • Apps/Diceware/manifest.properties
  • Apps/EpubReader/manifest.properties
  • Apps/EspNowBridge/manifest.properties
  • Apps/GPIO/manifest.properties
  • Apps/GraphicsDemo/manifest.properties
  • Apps/HelloWorld/manifest.properties
  • Apps/M5UnitTest/manifest.properties
  • Apps/Magic8Ball/manifest.properties
  • Apps/MediaKeys/manifest.properties
  • Apps/MystifyDemo/manifest.properties
  • Apps/SerialConsole/main/Source/ConnectView.cpp
  • Apps/SerialConsole/manifest.properties
  • Apps/Snake/main/Source/Snake.cpp
  • Apps/Snake/manifest.properties
  • Apps/TamaTac/main/Source/Achievements.cpp
  • Apps/TamaTac/main/Source/CemeteryView.cpp
  • Apps/TamaTac/main/Source/PetLogic.cpp
  • Apps/TamaTac/main/Source/SettingsView.cpp
  • Apps/TamaTac/manifest.properties
  • Apps/TodoList/manifest.properties
  • Apps/TwoEleven/main/Source/TwoEleven.cpp
  • Apps/TwoEleven/manifest.properties
  • Libraries/TactilityCpp/Include/TactilityCpp/App.h
  • Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
  • Libraries/TactilityCpp/Include/TactilityCpp/Preferences.h
  • Libraries/TactilityCpp/Include/TactilityCpp/Uart.h
  • Libraries/TactilityCpp/LICENSE.md
  • Libraries/TactilityCpp/README.md
💤 Files with no reviewable changes (6)
  • Libraries/TactilityCpp/README.md
  • Libraries/TactilityCpp/Include/TactilityCpp/Uart.h
  • Libraries/TactilityCpp/Include/TactilityCpp/LvglLock.h
  • Libraries/TactilityCpp/Include/TactilityCpp/App.h
  • Libraries/TactilityCpp/Include/TactilityCpp/Preferences.h
  • Libraries/TactilityCpp/LICENSE.md

Included review availability: Your plan provides up to 1 included review per hour; 0 remain after this review.

Comment thread Apps/Calculator/main/Source/Calculator.cpp Outdated
Comment thread Apps/Calculator/main/Source/Calculator.cpp
Comment thread Apps/SerialConsole/main/Source/ConnectView.cpp
Comment thread Apps/TamaTac/main/Source/Achievements.cpp
Comment thread Apps/TamaTac/main/Source/SettingsView.cpp
Comment thread Apps/TwoEleven/main/Source/TwoEleven.cpp
@KenVanHoeylandt
KenVanHoeylandt merged commit 4e85b28 into main Aug 20, 2026
21 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant