Repository navigation
Remove unused decoy-group margin features and computation - #153
Merged
Merged
Conversation
Apex-finder bench
Sensitivity + timing across canonical scenarioscommit a7180af |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Change
Remove the two decoy-group margin features from all rescorer lanes and from the result schema. Competition now sorts by group key only and scans each group for its highest score; it no longer sorts members by score or computes runner-up margins. Sequence deduplication still sorts by chemistry and score to keep the best duplicate. Bump the results format to 6 because two Parquet columns were removed.
Entrapment result
The feature-removal trial on one HeLa run used the same 1,753,338 competed candidates and identical raw scores:
The subsequent competition-sort cleanup has not been benchmarked on that run. The trial is exploratory evidence, not a calibration claim. Trial notebook.
Checks
task fmtcargo test -p timsseek -p timsseek_cli --lib(202 passed, 1 ignored)cargo test -p timsseek_cli --bin timsseek(110 passed)cargo clippy -p timsseek -p timsseek_cli --all-targets -- -D warnings