Repository navigation
Conversation
The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
🦋 Changeset detectedLatest commit: 4b0cfec The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Update the Solid peer range packages/solid-db/package.json, .changeset/solid-js-peer-cap.md |
The package manifest changes the solid-js peer range to ^1.9.0. The changeset records the patch and states that Solid 2 is unsupported. |
Priority:
Estimated code review effort: 1 (Trivial) | ~4 minutes
Change: Bug fix
Suggested reviewers: kyleamathews
Merge Risk: 
Minimal · up to 4b0cf
-
The scoped dependency update is ready to merge.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passed-
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)
-
Full details: Description check
-
Explanation
The description explains the dependency change and its motivation, but it omits the required Oracle Coverage and Release Impact sections. The checklist also does not confirm
pnpm testor explicitly confirm the generated changeset.Resolution
Add the Oracle Coverage section with the applicable evidence or explain why no practical oracle applies. Add the Release Impact section and select the changeset option. Update the checklist to confirm whether
pnpm testwas run and confirm that the changeset was generated.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
🎯 Changes
The Solid packages here declare an open-ended
solid-jspeer (>=1.x). Solid 2.0.0 is due shortly. Once it's taggedlatest, that range will accept it, sonpm installwill pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removessolid-js/store,createComputed,mergeProps/splitProps,onMount,batchand more.This PR changes each range from
>=Xto^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way@tanstack/solid-router2.x and@tanstack/solid-query6.x did it.Prereleases (
2.0.0-rc.*) never matched>=1.x, which is why nobody has run into this yet.✅ Checklist
peerDependenciesranges and a changeset change; no code changes.Summary by CodeRabbit
solid-jspeer dependency range to version 1.x, excluding unsupported 2.x releases.