Skip to content

fix(solid): cap solid-js peer range at ^1 - #2286

Open
ryansolid wants to merge 1 commit into
TanStack:mainfrom
ryansolid:solid-js-peer-cap
Open

ryansolid wants to merge 1 commit into
TanStack:mainfrom
ryansolid:solid-js-peer-cap

Conversation

@ryansolid

@ryansolid ryansolid commented Oct 28, 2026 •

Copy link
Copy Markdown

🎯 Changes

The Solid packages here declare an open-ended solid-js peer (>=1.x). Solid 2.0.0 is due shortly. Once it's tagged latest, that range will accept it, so npm install will pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removes solid-js/store, createComputed, mergeProps/splitProps, onMount, batch and more.

This PR changes each range from >=X to ^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way @tanstack/solid-router 2.x and @tanstack/solid-query 6.x did it.

Prereleases (2.0.0-rc.*) never matched >=1.x, which is why nobody has run into this yet.

✅ Checklist

  • Only peerDependencies ranges and a changeset change; no code changes.

Summary by CodeRabbit

  • Bug Fixes
    • Restricted the supported solid-js peer dependency range to version 1.x, excluding unsupported 2.x releases.

The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is
released, but these adapters are built for Solid 1.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
@changeset-bot

changeset-bot Bot commented Oct 28, 2026

Copy link
Copy Markdown

🦋 Changeset detected

Latest commit: 4b0cfec

The changes in this PR will be included in the next version bump.

This PR includes changesets to release 1 package
Name Type
@tanstack/solid-db Patch

Not sure what this means? Click here to learn what changesets are.

Click here if you're a maintainer who wants to add another changeset to this PR

@coderabbitai

coderabbitai Bot commented Oct 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

No actionable comments were generated in the recent review.

Recent review info
Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 8c5e3d9a-698f-436a-a83f-f5f5e4f04520
Commits

Reviewing files that changed from the base of the PR and between b305fb2 and 4b0cfec.

Files selected for processing: 2
  • .changeset/solid-js-peer-cap.md
  • packages/solid-db/package.json

Included review availability: This review used your included allowance. Your plan provides up to 8 included reviews per hour; 7 remain after this review.

Walkthrough

The @tanstack/solid-db package now requires solid-js version ^1.9.0 instead of >=1.9.0. A patch changeset records the peer range update and states that Solid 2 is unsupported.

Changes: Solid peer range

Layer / File(s) Summary
Update the Solid peer range
packages/solid-db/package.json, .changeset/solid-js-peer-cap.md
The package manifest changes the solid-js peer range to ^1.9.0. The changeset records the patch and states that Solid 2 is unsupported.

Priority: Normal

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Bug fix

Suggested reviewers: kyleamathews

Merge Risk: Minimal · up to 4b0cf

The scoped dependency update is ready to merge.

Pre-merge checks: Passed 4 · Failed 1

Failed Failed checks: 1 warning

Check name Status Explanation Resolution
Description check Warning The description explains the dependency change and its motivation, but it omits the required Oracle Coverage and Release Impact sections. The checklist also does not confirm pnpm test or explicitly … Add the Oracle Coverage section with the applicable evidence or explain why no practical oracle applies. Add the Release Impact section and select the changeset option. Update the checklist to confirm whether pnpm test was run and confirm…
Passed Passed checks: 4 passed
Check name Status Explanation
Title check Passed The title clearly and concisely states the primary change: capping the Solid peer dependency range at ^1.
Docstring Coverage Passed No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat…
Linked Issues check Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check Passed Check skipped because no linked issues were found for this pull request.
Full details: Docstring Coverage

Explanation

No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (2 skipped: 2 unsupported.)

Full details: Description check

Explanation

The description explains the dependency change and its motivation, but it omits the required Oracle Coverage and Release Impact sections. The checklist also does not confirm pnpm test or explicitly confirm the generated changeset.

Resolution

Add the Oracle Coverage section with the applicable evidence or explain why no practical oracle applies. Add the Release Impact section and select the changeset option. Update the checklist to confirm whether pnpm test was run and confirm that the changeset was generated.

Finishing Touches
🧪 Generate unit tests (beta)
  • Create a new PR
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant