Repository navigation
ci: restore release tests and public package publishing - #2299
Merged
Merged
Conversation
|
| Name | Type |
|---|---|
| @tanstack/angular-db | Major |
| @tanstack/browser-db-sqlite-persistence | Major |
| @tanstack/capacitor-db-sqlite-persistence | Major |
| @tanstack/cloudflare-durable-objects-db-sqlite-persistence | Major |
| @tanstack/convex-db-collection | Major |
| @tanstack/db | Major |
| @tanstack/db-ivm | Major |
| @tanstack/db-sqlite-persistence-core | Major |
| @tanstack/electric-db-collection | Major |
| @tanstack/electron-db-sqlite-persistence | Major |
| @tanstack/expo-db-sqlite-persistence | Major |
| @tanstack/node-db-sqlite-persistence | Major |
| @tanstack/offline-transactions | Minor |
| @tanstack/powersync-db-collection | Major |
| @tanstack/preact-db | Major |
| @tanstack/query-db-collection | Minor |
| @tanstack/react-db | Major |
| @tanstack/react-native-db-sqlite-persistence | Major |
| @tanstack/react-router-with-db | Major |
| @tanstack/rxdb-db-collection | Major |
| @tanstack/solid-db | Major |
| @tanstack/svelte-db | Major |
| @tanstack/tauri-db-sqlite-persistence | Major |
| @tanstack/trailbase-db-collection | Major |
| @tanstack/vue-db | Major |
| @tanstack/capacitor-db-sqlite-persistence-e2e-app | Patch |
| @tanstack/expo-db-sqlite-persistence-e2e-app | Patch |
| @tanstack/tauri-db-sqlite-persistence-e2e-app | Patch |
| offline-first-electron | Patch |
| offline-transactions-react-native | Patch |
| shopping-list-react-native | Patch |
| @tanstack/db-example-react-action-enforcement | Patch |
| @tanstack/db-example-react-todo | Patch |
| @tanstack/db-example-solid-todo | Patch |
Click here to learn what changesets are, and how to add one.
Click here if you're a maintainer who wants to add a changeset to this PR
Contributor
|
No actionable comments were generated in the recent review.
 |
| Layer / File(s) | Summary |
|---|---|
Database and package test matrices .github/workflows/release.yml |
The workflow tests database and package groups in separate matrices. Database groups upload JSON reports. The ivm-offline group also runs test-source typechecking and a dependency-version check. |
Release gate and report merge .github/workflows/release.yml, docs/contributing/oracle-coverage.md |
The release job now depends on lint and both test matrices. It downloads and merges database reports with Vitest. The coverage note records the successful release and remaining counterexamples. |
Restore RC package publication .changeset/first-rc.md, packages/convex-db-collection/package.json, packages/preact-db/package.json, packages/react-router-with-db/package.json, scripts/check-doc-snippets.mjs |
Changeset entries and package manifests restore publication eligibility for three packages. The documentation snippet checker includes exports from private workspace packages. |
Priority:
Estimated code review effort: 3 (Moderate) | ~20 minutes
Change: Bug fix
Sequence Diagram(s)
sequenceDiagram
participant test-db
participant test-packages
participant ArtifactStorage
participant ReleaseJob
participant Vitest
test-db->>ArtifactStorage: Upload database JSON reports
test-packages->>ReleaseJob: Complete package test matrix
ArtifactStorage->>ReleaseJob: Download database report artifacts
ReleaseJob->>Vitest: Merge database reports
Possibly related PRs
- TanStack/db#2171: Defines the first 1.0 RC release process and changeset that this PR updates.
- TanStack/db#2230: Adds Convex Collection and places it in the collections CI group covered by this PR’s matrix.
- TanStack/db#2103: Changes the same documentation snippet checker export mapping.
Merge Risk: 
68ca7
-
No actionable merge-blocking risk was found in the reviewed changes.
Pre-merge checks: 
-
Check name Status Explanation Title check The title clearly summarizes the main changes: restoring release tests and enabling public package publishing. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Description check The description follows the template's main sections (Changes, Oracle Coverage, Checklist, Release Impact) and gives clear, specific context: the purpose of restoring release test matrices and DB repo… Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 1 files. (2 skipped: 2 unsupported.)
Full details: Description check
-
Explanation
The description follows the template's main sections (Changes, Oracle Coverage, Checklist, Release Impact) and gives clear, specific context: the purpose of restoring release test matrices and DB report steps, the package privacy reversal, and the documentation-checker mapping fix. Oracle Coverage names the coverage-map entries and owner and explains that no runtime law, oracle, or budget changed. Release Impact is marked and explains the npm publishing implications. The main gap is the Checklist: the local-test box is unchecked and the author states the maintainer asked for no local tests, so the template's testing item is not satisfied. The description does not cover the RED/GREEN evidence needed for a bug-class fix, but this PR is a restoration and mapping fix, so that is not required.
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Contributor
|
Size Change: 0 B Total Size: 238 kB ℹ️ View Unchanged
|
More templates
@tanstack/angular-db
@tanstack/browser-db-sqlite-persistence
@tanstack/capacitor-db-sqlite-persistence
@tanstack/cloudflare-durable-objects-db-sqlite-persistence
@tanstack/convex-db-collection
@tanstack/db
@tanstack/db-ivm
@tanstack/db-sqlite-persistence-core
@tanstack/electric-db-collection
@tanstack/electron-db-sqlite-persistence
@tanstack/expo-db-sqlite-persistence
@tanstack/node-db-sqlite-persistence
@tanstack/offline-transactions
@tanstack/powersync-db-collection
@tanstack/preact-db
@tanstack/query-db-collection
@tanstack/react-db
@tanstack/react-native-db-sqlite-persistence
@tanstack/react-router-with-db
@tanstack/rxdb-db-collection
@tanstack/solid-db
@tanstack/svelte-db
@tanstack/tauri-db-sqlite-persistence
@tanstack/trailbase-db-collection
@tanstack/vue-db
commit: |
1 of 3 tasks
KyleAMathews
changed the title
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
The staged RC Release 40910451885 succeeded. Restore the previous Release test matrices, DB report upload/download/merge, and test dependencies. Restore Convex Collection, Preact DB, and React Router with DB to public packages by removing their temporary
private: trueflags and restoring their consumed first-RC changeset entries. Their versions remain1.0.0-rc.1; no new version bump is introduced.Marking those packages private in #2297 also removed their source mappings from the documentation checker and failed PR Lint. Map typed workspace exports regardless of publication eligibility so documented workspace packages use their source types. The snippet assertions and baseline are unchanged.
🔬 Oracle Coverage
Relevant coverage-map entries: RC scope partition and RC release histories and replay observations, whose shared independent owner is
scripts/release-history-oracle.js. This restores previously approved workflow and package metadata. No runtime law, oracle model, history, comparison, reach requirement, or budget changes. The snippet checker maps actual workspace source exports; snippet assertions and baseline are unchanged. Full bug-class closure is not claimed.The workflow, three package manifests, and first-RC changeset are byte-identical to
07bfc0eb2584fd83a3efc14ec1fb452954a829ea. Changed-file oracle lint, Prettier and whitespace checks passed. CodeRabbit completed its incremental review at68ca7007408fdd63fa2d80a3e22832ec8c076f10with zero actionable findings; the three manifest deletions were classified as no reviewable changes and coverage prose was similarity-skipped. CI remains the verification of this updated head.✅ Checklist
pnpm test.The maintainer explicitly requested no local tests or builds. No local test, build, doc-snippet replay, RED/GREEN or mutant run is claimed.
🚀 Release Impact
The successful staged release reported all 20 included RC versions at 1.0.0-rc.1 and Query Collection 1.5.0 / Offline Transactions 1.2.0 already present on npm. Restoring the three packages makes them eligible for automated publishing again; initial manual publication and trusted publisher permissions still need verification, and an unresolved permission issue can fail a later Release. This PR does not change npm tags. #2300 separately changes future RC uploads to latest; existing version tags need explicit promotion. Full readiness is not assessed; #2294, #2281, #2296, and the reach gap tracked in #2287 remain open.