Repository navigation
Conversation
The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
🦋 Changeset detectedLatest commit: 17095b7 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
 |
| Layer / File(s) | Summary |
|---|---|
Peer range and patch release packages/devtools-a11y/package.json, packages/devtools-ui/package.json, packages/devtools-utils/package.json, packages/devtools/package.json, packages/solid-devtools/package.json, .changeset/solid-js-peer-cap.md |
The five package manifests narrow the solid-js peer range to ^1.9.7. The changeset marks all five packages for patch releases and describes their Solid 1 compatibility. |
Priority:
Estimated code review effort: 2 (Simple) | ~10 minutes
Change: Bug fix
Suggested reviewers: alemtuzlak
Merge Risk: 
dba6f
-
No actionable merge-blocking risk remains in this dependency-range-only change.
Pre-merge checks: 
-
Check name Status Explanation Description check The description clearly explains the peer dependency changes, the Solid 2 compatibility risk, the affected packages, and the changeset. It includes the Changes section and a checklist, but it omits se… Title check The title is concise and accurately describes the main change: capping the solid-js peer range at ^1. Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Description check
-
Explanation
The description clearly explains the peer dependency changes, the Solid 2 compatibility risk, the affected packages, and the changeset. It includes the Changes section and a checklist, but it omits several template checklist items and the Release Impact section.
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (6 skipped: 6 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
🎯 Changes
The Solid packages here declare an open-ended
solid-jspeer (>=1.x). Solid 2.0.0 is due shortly. Once it's taggedlatest, that range will accept it, sonpm installwill pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removessolid-js/store,createComputed,mergeProps/splitProps,onMount,batchand more.This PR changes each range from
>=Xto^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way@tanstack/solid-router2.x and@tanstack/solid-query6.x did it.Prereleases (
2.0.0-rc.*) never matched>=1.x, which is why nobody has run into this yet.✅ Checklist
peerDependenciesranges and a changeset change; no code changes.Devtools specifics
@tanstack/devtoolsand@tanstack/devtools-uilistsolid-jsboth as a dependency and as a peer. The peer stays, now capped at^1, because it keeps the shell on the app's Solid instance: the shell calls each plugin'srenderinside its own effect,@tanstack/solid-devtoolsanswers with aPortalbuilt from the app'ssolid-js, and@tanstack/devtools-a11yusesdevtools-uicomponents with its own Solid store and contexts. All five Solid-dependent devtools packages (devtools,devtools-ui,devtools-utils,devtools-a11y,solid-devtools) are capped the same way until they get a Solid 2 entry.Summary by CodeRabbit