Repository navigation
Conversation
The open-ended >= range lets solid-js 2.0.0 satisfy the peer once it is released, but these adapters are built for Solid 1. Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com> Claude-Session: https://claude.ai/code/session_0117BoWMMJ6aTSA3MvtgJWG2
🦋 Changeset detectedLatest commit: dadc504 The changes in this PR will be included in the next version bump. This PR includes changesets to release 14 packages
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
|
Important Review skippedReview was skipped due to path filters ⛔ Files ignored due to path filters: 1
CodeRabbit blocks several paths by default. You can override this behavior by explicitly including those paths in the path filters. For example, including
 |
| Layer / File(s) | Summary |
|---|---|
Peer range updates packages/solid-form/package.json, packages/form-devtools/package.json, packages/solid-form-devtools/package.json, .changeset/solid-js-peer-cap.md |
The three package manifests replace open-ended minimum solid-js peer ranges with ^1.9.9 or ^1.9.7. The changeset records a patch release for the packages. |
Priority:
Estimated code review effort: 2 (Simple) | ~5 minutes
Change: Bug fix
Merge Risk: 
bc1bb
-
The dependency range update and accompanying changeset are consistent with the stated compatibility goal and appear ready to merge.
Pre-merge checks: 
-
Check name Status Explanation Title check The title "fix(solid): cap solid-js peer range at ^1" matches the main change. The PR changes the solid-js peerDependencies in three packages from open-ended >=X ranges to ^X ranges, and adds a patch … Description check The description follows the template structure. It has a Changes section that explains the motivation: Solid 2.0.0 could satisfy the open-ended solid-js peer range and break Solid 1 adapters. It state… Docstring Coverage No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentat… Linked Issues check Check skipped because no linked issues were found for this pull request. Out of Scope Changes check Check skipped because no linked issues were found for this pull request. Full details: Title check
-
Explanation
The title "fix(solid): cap solid-js peer range at ^1" matches the main change. The PR changes the solid-js peerDependencies in three packages from open-ended >=X ranges to ^X ranges, and adds a patch changeset. The title names the scope (solid), the action (cap the peer range), and the version bound (^1). It follows the conventional commit style.
Full details: Description check
-
Explanation
The description follows the template structure. It has a Changes section that explains the motivation: Solid 2.0.0 could satisfy the open-ended solid-js peer range and break Solid 1 adapters. It states the change: each range goes from >=X to ^X, and a patch changeset is added. The Checklist section is present, but only one item is ticked. The description does not state whether the tests were run with pnpm test:pr, and it does not confirm the contributing guide steps or the AI-assistance understanding item. The Release Impact section is missing, although the changeset covers that point.
Resolution
Optional improvements: tick or address the remaining checklist items, including the pnpm test:pr item and the AI-assistance item. Mark the Release Impact checkbox that applies (the changeset makes this a published change).
Full details: Docstring Coverage
-
Explanation
No eligible functions found in the changed files. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 0 functions across 0 files. (4 skipped: 4 unsupported.)
-
Finishing Touches
-
🧪 Generate unit tests (beta)
-
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Comment @coderabbitai help to get the list of available commands.
Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
|
View your CI Pipeline Execution ↗ for commit dadc504
☁️ Nx Cloud last updated this comment at |
|
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #2456 +/- ##
==========================================
- Coverage 90.35% 89.78% -0.57%
==========================================
Files 38 66 +28
Lines 1752 3232 +1480
Branches 444 812 +368
==========================================
+ Hits 1583 2902 +1319
- Misses 149 296 +147
- Partials 20 34 +14 ☔ View full report in Codecov by Harness. 🚀 New features to boost your workflow:
|
🎯 Changes
The Solid packages here declare an open-ended
solid-jspeer (>=1.x). Solid 2.0.0 is due shortly. Once it's taggedlatest, that range will accept it, sonpm installwill pair these Solid 1 adapters with Solid 2 without any peer warning, and they will fail at build or run time: Solid 2 removessolid-js/store,createComputed,mergeProps/splitProps,onMount,batchand more.This PR changes each range from
>=Xto^X, keeping the same lower bound, and adds a patch changeset so the cap actually ships. Solid 2 support can then come as a new adapter major on a pre-release branch, the way@tanstack/solid-router2.x and@tanstack/solid-query6.x did it.Prereleases (
2.0.0-rc.*) never matched>=1.x, which is why nobody has run into this yet.✅ Checklist
peerDependenciesranges and a changeset change; no code changes.Summary by CodeRabbit