test({react,preact,solid,svelte}-query,angular-query-experimental): rename 'mutationFn' param to '_variables' in 'MutationFunctionContext' tests - #11448
Merged
Conversation
|
View your CI Pipeline Execution ↗ for commit e5b5cde
☁️ Nx Cloud last updated this comment at |
…ename 'mutationFn' param to '_variables' in 'MutationFunctionContext' tests
sukvvon
force-pushed
the
test/mutation-context-vars-naming
branch
from
September 8, 2026 12:11
e5b5cde to
43c9835
Compare
Contributor
🚀 Changeset Version Preview2 package(s) bumped directly, 23 bumped as dependents. 🟨 Minor bumps
🟩 Patch bumps
|
sukvvon
changed the title
Contributor
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
Included review availability: Your plan provides up to 10 included reviews per hour; 8 remain after this review. 📝 WalkthroughWalkthroughThe PR updates mutation context typing tests across Angular, Preact, React, Solid, and Svelte. The callback parameter is renamed to ChangesMutation context typing tests
Priority: ⬇️ Low — Defer this test-only parameter rename because it makes no published-code or behavioral change across the query packages. Estimated code review effort: 1 (Trivial) | ~2 minutes Merge Risk: ⚪ Minimal · up to This updates mutation callback type tests to infer the variables parameter across five framework packages, without changing published runtime behavior or APIs. No current merge-readiness risk is identified. 🚥 Pre-merge checks | ✅ 5✅ Passed checks (5 passed)
✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Contributor
size-limit report 📦
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🎯 Changes
Follow-up to #11440–#11444, which added a
should type context as the last argument for mutationFn and every hook-level callbacktype test toreact-query,preact-query,solid-query,svelte-query,angular-query-experimental, andvue-query.In each file's test, the
mutationFn's first parameter was named_vars: string, while the siblingonMutate/onSuccess/onError/onSettledcallbacks in the same test (and every othermutationFnin the file) use_variables.vue-query's copy was already fixed in #11444; this applies the same fix — renaming to_variablesand dropping the now-redundant: stringannotation (the type is still contextually inferred fromuseMutation/injectMutation/createMutation, as verified by each package's--typecheckrun) — to the remaining 5 adapters.✅ Checklist
pnpm run test:pr, or these tests do not apply to this pull request.🚀 Release Impact
Summary by CodeRabbit