Skip to content

chore(*): manage 'react' packages with pnpm 'catalog' - #11712

Merged
sukvvon merged 1 commit into
mainfrom
chore/catalog-react
Sep 28, 2026
Merged

sukvvon merged 1 commit into
mainfrom
chore/catalog-react

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

  • Add a # react section to the catalog in pnpm-workspace.yaml with @testing-library/react, @types/react, @types/react-dom, @vitejs/plugin-react, react, and react-dom, keeping the versions already declared.
  • Use catalog: for these devDependencies in the root package.json, query-broadcast-client-experimental, react-query, react-query-devtools, react-query-next-experimental, and react-query-persist-client. The peerDependencies ranges are unchanged.
  • Point the @types/react and @types/react-dom overrides to catalog: so they follow the same version.
  • Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Standardized version references for shared React-related packages across project components, keeping their declarations consistent. No changes to application functionality or public APIs are included. These updates do not alter the behavior of the app or its tools.

@sukvvon sukvvon self-assigned this Sep 28, 2026
@nx-cloud

nx-cloud Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 42415fd

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 7m 53s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 29s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 09:48:35 UTC

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 6cbdce1b-bcdc-4303-99e8-26333280e63d

📥 Commits

Reviewing files that changed from the base of the PR and between 2e1ad64 and 42415fd.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (7)
  • package.json
  • packages/query-broadcast-client-experimental/package.json
  • packages/react-query-devtools/package.json
  • packages/react-query-next-experimental/package.json
  • packages/react-query-persist-client/package.json
  • packages/react-query/package.json
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.


📝 Walkthrough

Walkthrough

The workspace catalog now defines versions for React-related dependencies. The root and package manifests use catalog references for the listed dependencies.

Changes

React dependency catalogs

Layer / File(s) Summary
Define workspace catalog entries
pnpm-workspace.yaml
Adds catalog entries for React, React DOM, their type packages, Testing Library for React, and the Vite React plugin. The React type-package overrides now use catalog references.
Use catalog references in package manifests
package.json, packages/query-broadcast-client-experimental/package.json, packages/react-query-devtools/package.json, packages/react-query-next-experimental/package.json, packages/react-query-persist-client/package.json, packages/react-query/package.json
Replaces explicit versions with catalog references for the listed dependencies. The next dependency and the React render-stream and peer dependency declarations remain unchanged.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 42415

This change centralizes React dependency versions without an evidenced change to their resolved versions, so no material merge risk remains.

Architecture Summary

Architecture risk: 🔵 Low · up to 42415

The change affects 7 systems.

Changed systems: package.json, packages/query-broadcast-client-experimental, packages/react-query, packages/react-query-devtools, packages/react-query-next-experimental, packages/react-query-persist-client, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — package.json (service) was modified; 1 changed file maps to changed impact.
  • observed — packages/query-broadcast-client-experimental (library) was modified; 1 changed file maps to changed impact.
  • observed — packages/react-query (library) was modified; 1 changed file maps to changed impact.
  • observed — packages/react-query-devtools (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in package.json: @types/react and @types/react-dom now resolve through the catalog: entries instead of their explicit version ranges.
  • observed — Modified behavior in package.json: react and react-dom now resolve through the catalog: entries instead of the explicit ^19.2.1 ranges.
  • observed — Modified behavior in packages/query-broadcast-client-experimental/package.json: Both development dependencies replace explicit version ranges with catalog: references.
  • observed — Modified behavior in packages/react-query-devtools/package.json: These four devDependencies replace explicit version ranges with catalog: specifications.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Description check ✅ Passed The description includes the required Changes, Checklist, and Release Impact sections. It explains the catalog updates, confirms testing and policy checks, and correctly identifies the change as dev-o…
Title check ✅ Passed The title clearly and concisely describes the main change: managing React packages with the pnpm catalog.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11712

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11712

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11712

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11712

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11712

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11712

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11712

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11712

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11712

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11712

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11712

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11712

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11712

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11712

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11712

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11712

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11712

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11712

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11712

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11712

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11712

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11712

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11712

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11712

commit: 42415fd

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.73 KB (0%)
react minimal 8.58 KB (0%)

@sukvvon
sukvvon merged commit e878990 into main Sep 28, 2026
9 checks passed
@sukvvon
sukvvon deleted the chore/catalog-react branch September 28, 2026 09:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant