chore(preact-query*): manage 'preact' packages with pnpm 'catalog' by sukvvon · Pull Request #11713 · TanStack/query

sukvvon · 2026-09-28T09:51:44Z

🎯 Changes

Add a # preact section to the catalog in pnpm-workspace.yaml with @preact/preset-vite, @testing-library/preact, and preact, keeping the versions already declared.
Use catalog: for these devDependencies in preact-query, preact-query-devtools, and preact-query-persist-client. The peerDependencies range of preact is unchanged.
Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Centralized the development tool versions used across the Preact packages in the workspace catalog.

nx-cloud · 2026-09-28T09:52:09Z

View your CI Pipeline Execution ↗ for commit 005a1c8

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	5m 58s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	27s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 09:58:49 UTC

github-actions · 2026-09-28T09:52:39Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-28T09:53:20Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 324d5276-4d48-4c0a-912a-2daa59424feb

📥 Commits

Reviewing files that changed from the base of the PR and between e878990 and 005a1c8.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (4)

packages/preact-query-devtools/package.json
packages/preact-query-persist-client/package.json
packages/preact-query/package.json
pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The workspace catalog now defines versions for three Preact development dependencies. The devtools, persist-client, and query packages use catalog references for those dependencies.

Changes

Preact development dependency catalog

Layer / File(s)	Summary
Define and use catalog entries `pnpm-workspace.yaml`, `packages/preact-query/package.json`, `packages/preact-query-persist-client/package.json`, `packages/preact-query-devtools/package.json`	The workspace catalog adds version ranges for `@preact/preset-vite`, `@testing-library/preact`, and `preact`. Each package uses catalog references for these development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~4 minutes

Change: Other

Suggested reviewers: tkdodo

Merge Risk: ⚪ Minimal · up to 005a1

This change centralizes existing development dependency versions without an indicated behavior change. No merge-blocking issue is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 005a1

The change affects 4 systems.

Changed systems: packages/preact-query, packages/preact-query-devtools, packages/preact-query-persist-client, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/preact-query (library) was modified; 1 changed file maps to changed impact.
observed — packages/preact-query-devtools (library) was modified; 1 changed file maps to changed impact.
observed — packages/preact-query-persist-client (library) was modified; 1 changed file maps to changed impact.
observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in packages/preact-query-devtools/package.json: The three devDependency version ranges for @preact/preset-vite, @testing-library/preact, and preact were replaced with "catalog:" references; the intervening @tanstack/preact-query and eslint-config-preact entries are unchanged.
observed — Modified behavior in packages/preact-query-persist-client/package.json: Three development dependency declarations switch from explicit version ranges to catalog references: @preact/preset-vite, @testing-library/preact, and preact. The intervening dependencies are unchanged.
observed — Modified behavior in packages/preact-query/package.json: The @preact/preset-vite, @testing-library/preact, and preact development dependency declarations replace explicit version ranges with catalog:; the other development dependency declarations in this block are unchanged.
observed — Modified behavior in pnpm-workspace.yaml: The dependency catalog adds version ranges for the Preact Vite preset, Preact Testing Library, and Preact.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly describes the main change: managing Preact package versions with the pnpm catalog across the preact-query packages.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the catalog updates, confirms testing and policy checks, and marks the change as dev-only with no rel…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-28T09:53:38Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11713

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11713

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11713

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11713

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11713

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11713

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11713

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11713

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11713

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11713

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11713

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11713

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11713

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11713

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11713

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11713

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11713

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11713

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11713

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11713

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11713

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11713

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11713

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11713

commit: 005a1c8

github-actions · 2026-09-28T09:54:29Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(preact-query*): manage 'preact' packages with pnpm 'catalog'

005a1c8

sukvvon self-assigned this Sep 28, 2026

sukvvon marked this pull request as draft September 28, 2026 09:58

Navigation Menu

Uh oh!

chore(preact-query*): manage 'preact' packages with pnpm 'catalog' - #11713

chore(preact-query*): manage 'preact' packages with pnpm 'catalog'#11713
sukvvon wants to merge 1 commit into
mainfrom
chore/catalog-preact

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

size-limit report 📦

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading