chore(*): manage 'solid' packages with pnpm 'catalog' by sukvvon · Pull Request #11714 · TanStack/query

sukvvon · 2026-09-28T09:53:13Z

🎯 Changes

Add a # solid section to the catalog in pnpm-workspace.yaml with @solidjs/testing-library, solid-js, unplugin-solid, and vite-plugin-solid, keeping the versions already declared.
Use catalog: for these devDependencies in query-devtools, solid-query, solid-query-devtools, and solid-query-persist-client. The solid-js entry in dependencies of query-devtools and the peerDependencies range of solid-js are unchanged.
Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Standardized how development tooling versions are managed across the Solid packages and their shared workspace configuration.
- These maintenance updates do not change user-facing features or behavior.

nx-cloud · 2026-09-28T09:53:39Z

View your CI Pipeline Execution ↗ for commit c34c44c

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	6m 50s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	37s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 10:01:07 UTC

github-actions · 2026-09-28T09:54:10Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-28T09:54:31Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Draft PR not reviewed

Draft PRs are not automatically reviewed by default.

Trigger a manual review

To automatically review draft PRs, update your CodeRabbit configuration:

reviews:
  auto_review:
    drafts: true

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 7ad571b3-b60a-4a49-af14-b60a01e53e2e

📥 Commits

Reviewing files that changed from the base of the PR and between e878990 and c34c44c.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (5)

packages/query-devtools/package.json
packages/solid-query-devtools/package.json
packages/solid-query-persist-client/package.json
packages/solid-query/package.json
pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The workspace dependency catalog now defines versions for Solid testing utilities, the Solid runtime, and Solid plugins. Four package manifests use catalog references for selected Solid development dependencies.

Changes

Solid dependency catalog

Layer / File(s)	Summary
Add Solid dependency catalog entries `pnpm-workspace.yaml`	The workspace catalog adds version entries for Solid testing utilities, the Solid runtime, and Solid plugins.
Use catalog references in package manifests `packages/query-devtools/package.json`, `packages/solid-query-devtools/package.json`, `packages/solid-query-persist-client/package.json`, `packages/solid-query/package.json`	The package manifests replace explicit version ranges with catalog references for selected Solid development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~5 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to c34c4

The Solid development dependencies are centralized without changing their resolved versions, and the supplied context identifies no remaining merge-blocking issue.

Architecture Summary

Architecture risk: 🔵 Low · up to c34c4

The change affects 5 systems.

Changed systems: packages/query-devtools, packages/solid-query, packages/solid-query-devtools, packages/solid-query-persist-client, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/query-devtools (library) was modified; 1 changed file maps to changed impact.
observed — packages/solid-query (library) was modified; 1 changed file maps to changed impact.
observed — packages/solid-query-devtools (library) was modified; 1 changed file maps to changed impact.
observed — packages/solid-query-persist-client (library) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in packages/query-devtools/package.json: The @solidjs/testing-library, unplugin-solid, and vite-plugin-solid devDependencies switch from fixed version ranges to catalog: references; the TypeScript entry is unchanged.
observed — Modified behavior in packages/solid-query-devtools/package.json: In devDependencies, the testing library, Solid runtime, and two Solid plugins switch from explicit version ranges to catalog references; the Solid Query workspace and TypeScript catalog entries remain unchanged.
observed — Modified behavior in packages/solid-query-persist-client/package.json: Four devDependencies switch from explicit version ranges to "catalog:"; the other three dependencies in this block retain their existing values.
observed — Modified behavior in packages/solid-query/package.json: The development dependency entries for @solidjs/testing-library, solid-js, unplugin-solid, and vite-plugin-solid now use catalog: instead of their previous version ranges. The @tanstack/query-test-utils and typescript entries are unchanged.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the main change: managing Solid packages with the pnpm catalog.
Description check	✅ Passed	The description explains the catalog changes, lists affected packages, documents unchanged dependencies and lockfile behavior, completes the checklist, and identifies the change as dev-only.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-28T09:55:27Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11714

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11714

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11714

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11714

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11714

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11714

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11714

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11714

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11714

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11714

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11714

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11714

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11714

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11714

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11714

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11714

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11714

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11714

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11714

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11714

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11714

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11714

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11714

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11714

commit: c34c44c

github-actions · 2026-09-28T09:56:30Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

# Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml

chore(*): manage 'solid' packages with pnpm 'catalog'

c34c44c

sukvvon self-assigned this Sep 28, 2026

sukvvon marked this pull request as draft September 28, 2026 09:58

Merge remote-tracking branch 'origin/main' into chore/catalog-solid

4cd4726

# Conflicts: # pnpm-lock.yaml # pnpm-workspace.yaml

Navigation Menu

Uh oh!

chore(*): manage 'solid' packages with pnpm 'catalog' - #11714

chore(*): manage 'solid' packages with pnpm 'catalog'#11714
sukvvon wants to merge 2 commits into
mainfrom
chore/catalog-solid

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Draft PR not reviewed

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Draft PR not reviewed

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026

Uh oh!

github-actions Bot commented Sep 28, 2026

size-limit report 📦

Uh oh!

This branch has not been deployed

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading