Skip to content

chore(svelte-query*): manage 'svelte' packages with pnpm 'catalog' - #11715

Merged
sukvvon merged 2 commits into
mainfrom
chore/catalog-svelte
Sep 28, 2026
Merged

sukvvon merged 2 commits into
mainfrom
chore/catalog-svelte

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

  • Add a # svelte section to the catalog in pnpm-workspace.yaml with @sveltejs/package, @sveltejs/vite-plugin-svelte, @testing-library/svelte, svelte, and svelte-check, keeping the versions already declared.
  • Use catalog: for these devDependencies in svelte-query, svelte-query-devtools, and svelte-query-persist-client. The peerDependencies range of svelte is unchanged.
  • Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Standardized development tooling version management across the Svelte packages using shared workspace settings. These changes affect project setup only; no user-facing features or application behavior have changed.

@sukvvon sukvvon self-assigned this Sep 28, 2026
@nx-cloud

nx-cloud Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit d5bf753

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 7m 48s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 25s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 16:29:29 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 10eaa27b-39e6-45a2-a01f-09ca1cc0d845

📥 Commits

Reviewing files that changed from the base of the PR and between f8caab1 and d5bf753.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.


📝 Walkthrough

Walkthrough

The workspace catalog now defines versions for five Svelte tooling packages. The Svelte Query, Svelte Query Devtools, and Svelte Query Persist Client manifests use the catalog entries for their development dependencies.

Changes

Svelte tooling catalog

Layer / File(s) Summary
Define and apply shared versions
pnpm-workspace.yaml, packages/svelte-query/package.json, packages/svelte-query-devtools/package.json, packages/svelte-query-persist-client/package.json
The workspace catalog adds version ranges for five Svelte tooling packages. The three package manifests now reference those catalog entries instead of explicit ranges.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to d5bf7

This change centralizes existing Svelte dependency versions without changing resolved packages or the supported pnpm setup. No merge-blocking risk is identified.

Architecture Summary

Architecture risk: 🔵 Low · up to d5bf7

The change affects 4 systems.

Changed systems: packages/svelte-query, packages/svelte-query-devtools, packages/svelte-query-persist-client, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/svelte-query (library) was modified; 1 changed file maps to changed impact.
  • observed — packages/svelte-query-devtools (library) was modified; 1 changed file maps to changed impact.
  • observed — packages/svelte-query-persist-client (library) was modified; 1 changed file maps to changed impact.
  • observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/svelte-query-devtools/package.json: Five devDependencies now resolve versions through the catalog instead of their previous explicit ranges; the other three entries in the block are unchanged.
  • observed — Modified behavior in packages/svelte-query-persist-client/package.json: Five development dependencies now resolve through the workspace catalog rather than the previous explicit versions: @sveltejs/package, @sveltejs/vite-plugin-svelte, @testing-library/svelte, svelte, and svelte-check.
  • observed — Modified behavior in packages/svelte-query/package.json: Five dev dependency version specifications now use catalog: instead of their former explicit ranges; the other entries in the block retain their prior values.
  • observed — Modified behavior in pnpm-workspace.yaml: Adds catalog version ranges for Svelte packaging, Vite integration, testing, runtime, and type-checking dependencies.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly and concisely describes the main change: managing Svelte package versions with the pnpm catalog.
Description check ✅ Passed The description follows the required template. It explains the changes, completes the checklist, and identifies the change as development-only with no release impact.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11715

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11715

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11715

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11715

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11715

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11715

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11715

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11715

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11715

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11715

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11715

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11715

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11715

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11715

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11715

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11715

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11715

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11715

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11715

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11715

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11715

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11715

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11715

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11715

commit: d5bf753

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.73 KB (0%)
react minimal 8.58 KB (0%)

@sukvvon
sukvvon marked this pull request as draft September 28, 2026 09:58
@sukvvon
sukvvon marked this pull request as ready for review September 28, 2026 16:20
@sukvvon
sukvvon merged commit cddf804 into main Sep 28, 2026
9 checks passed
@sukvvon
sukvvon deleted the chore/catalog-svelte branch September 28, 2026 16:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant