Skip to content

chore(vue-query*): manage 'vue' packages with pnpm 'catalog' - #11716

Merged
sukvvon merged 2 commits into
mainfrom
chore/catalog-vue
Sep 28, 2026
Merged

sukvvon merged 2 commits into
mainfrom
chore/catalog-vue

Conversation

@sukvvon

@sukvvon sukvvon commented Sep 28, 2026 •

Copy link
Copy Markdown
Member

🎯 Changes

  • Add a # vue section to the catalog in pnpm-workspace.yaml with unplugin-vue and vue, keeping the versions already declared.
  • Use catalog: for these devDependencies in vue-query and vue-query-devtools. The peerDependencies ranges of vue are unchanged.
  • Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

  • I have followed the steps in the Contributing guide.
  • I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
  • I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

  • This change affects published code, and I have generated a changeset.
  • This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

  • Chores
    • Updated the Vue packages’ development dependency version references to use the shared workspace catalog. The catalog specifies unplugin-vue at ^8.0.0 and vue at ^3.5.43. These updates affect development dependency configuration; no application features or behavior changed.

@sukvvon sukvvon self-assigned this Sep 28, 2026
@nx-cloud

nx-cloud Bot commented Sep 28, 2026 •

Copy link
Copy Markdown

View your CI Pipeline Execution ↗ for commit 3e70c98

Command Status Duration Result
nx affected --targets=test:sherif,test:knip,tes... ✅ Succeeded 8m 20s View ↗
nx run-many --target=build --exclude=examples/*... ✅ Succeeded 28s View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 16:44:37 UTC

@github-actions

Copy link
Copy Markdown
Contributor

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

@coderabbitai

coderabbitai Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
Contributor

Review in Change Stack →

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info
⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: ae520471-938d-405a-b006-8e163d6f2342

📥 Commits

Reviewing files that changed from the base of the PR and between 1866776 and 3e70c98.

⛔ Files ignored due to path filters (1)
  • pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml
📒 Files selected for processing (1)
  • pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.


📝 Walkthrough

Walkthrough

The workspace catalog now defines version ranges for unplugin-vue and vue. The vue-query and vue-query-devtools package manifests use catalog references for these development dependencies.

Changes

Vue dependency catalog

Layer / File(s) Summary
Define and use Vue dependency catalog
pnpm-workspace.yaml, packages/vue-query/package.json, packages/vue-query-devtools/package.json
The workspace catalog defines unplugin-vue as ^8.0.0 and vue as ^3.5.43. Both package manifests use catalog references for these development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 3e70c

This change centralizes the existing Vue development dependency ranges without changing resolved versions. Repository CI selects a pnpm version that supports catalogs, so no merge-blocking impact is evident.

Architecture Summary

Architecture risk: 🔵 Low · up to 3e70c

The change affects 3 systems.

Changed systems: packages/vue-query, packages/vue-query-devtools, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

  • observed — packages/vue-query (library) was modified; 1 changed file maps to changed impact.
  • observed — packages/vue-query-devtools (library) was modified; 1 changed file maps to changed impact.
  • observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

  • observed — Modified behavior in packages/vue-query-devtools/package.json: The unplugin-vue and vue development dependency ranges (^8.0.0 and ^3.5.43) were replaced with catalog: references.
  • observed — Modified behavior in packages/vue-query/package.json: The unplugin-vue and vue devDependencies now use "catalog:" instead of the explicit ranges ^8.0.0 and ^3.5.43.
  • observed — Modified behavior in pnpm-workspace.yaml: Added a Vue catalog section defining version ranges for unplugin-vue and vue.
🚥 Pre-merge checks | ✅ 5
✅ Passed checks (5 passed)
Check name Status Explanation
Title check ✅ Passed The title clearly describes the main change: managing Vue packages with pnpm catalog references.
Description check ✅ Passed The description covers the changes, testing, contribution requirements, AI policy, and release impact. It matches the repository template and marks the change as dev-only with no release.
Docstring Coverage ✅ Passed No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check ✅ Passed Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check ✅ Passed Check skipped because no linked issues were found for this pull request.
✨ Finishing Touches
🧪 Generate unit tests (beta)
  • Commit to this branch
  • Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@pkg-pr-new

pkg-pr-new Bot commented Sep 28, 2026 •

Copy link
Copy Markdown
More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11716

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11716

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11716

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11716

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11716

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11716

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11716

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11716

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11716

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11716

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11716

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11716

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11716

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11716

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11716

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11716

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11716

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11716

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11716

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11716

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11716

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11716

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11716

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11716

commit: 3e70c98

@github-actions

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size
react full 11.73 KB (0%)
react minimal 8.58 KB (0%)

@sukvvon
sukvvon marked this pull request as draft September 28, 2026 09:58
@sukvvon
sukvvon marked this pull request as ready for review September 28, 2026 16:36
@sukvvon
sukvvon merged commit 8d321c5 into main Sep 28, 2026
9 checks passed
@sukvvon
sukvvon deleted the chore/catalog-vue branch September 28, 2026 16:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant