chore(angular-query*): manage 'angular' packages with pnpm 'catalog' by sukvvon · Pull Request #11717 · TanStack/query

sukvvon · 2026-09-28T09:56:55Z

🎯 Changes

Add an # angular section to the catalog in pnpm-workspace.yaml with @analogjs/vite-plugin-angular, @angular/common, @angular/compiler, @angular/core, @angular/platform-browser, and @testing-library/angular, keeping the versions already declared.
Use catalog: for these devDependencies in angular-query-experimental and angular-query-persist-client. The peerDependencies ranges of @angular/common and @angular/core are unchanged.
Update pnpm-lock.yaml (only specifiers change, resolved versions are the same).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Chores
- Angular development and testing tools, along with Angular framework packages, now use shared workspace versions across the affected packages. This aligns their development environments and does not change application functionality or introduce changes visible in the product.

nx-cloud · 2026-09-28T09:57:37Z

View your CI Pipeline Execution ↗ for commit 91a311e

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 16s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	28s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-28 16:54:15 UTC

github-actions · 2026-09-28T09:58:01Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-28T09:58:22Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: fa4bb90a-3d82-48d1-b079-2440dba95d89

📥 Commits

Reviewing files that changed from the base of the PR and between 91c3a04 and 91a311e.

⛔ Files ignored due to path filters (1)

pnpm-lock.yaml is excluded by !**/pnpm-lock.yaml

📒 Files selected for processing (1)

pnpm-workspace.yaml

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The workspace dependency catalog now defines Angular-related package versions. Two Angular packages use catalog references for corresponding development dependencies instead of explicit version ranges.

Changes

Angular dependency catalog

Layer / File(s)	Summary
Catalog entries and package references `pnpm-workspace.yaml`, `packages/angular-query-experimental/package.json`, `packages/angular-query-persist-client/package.json`	The workspace catalog adds versions for the Angular Vite plugin, Angular packages, and Angular Testing Library. Both package manifests use catalog references for corresponding development dependencies.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Suggested reviewers: lachlancollins

Merge Risk: ⚪ Minimal · up to 91a31

The catalog references match the lockfile, and CI uses the declared pnpm version. No merge-blocking risk was identified.

Architecture Summary

Architecture risk: 🔵 Low · up to 91a31

The change affects 3 systems.

Changed systems: packages/angular-query-experimental, packages/angular-query-persist-client, pnpm-workspace.yaml

Architecture concerns
No architecture-level concerns identified.

Review details

Systems and components

observed — packages/angular-query-experimental (library) was modified; 1 changed file maps to changed impact.
observed — packages/angular-query-persist-client (library) was modified; 1 changed file maps to changed impact.
observed — pnpm-workspace.yaml (service) was modified; 1 changed file maps to changed impact.

Before / after behavior

observed — Modified behavior in packages/angular-query-experimental/package.json: The Vite Angular plugin and Angular common, compiler, core, and platform-browser development dependencies now resolve versions through the workspace catalog instead of their ^2.7.5 and ^20.0.0 ranges.
observed — Modified behavior in packages/angular-query-experimental/package.json: @testing-library/angular now uses the workspace catalog instead of the ^18.0.0 version range.
observed — Modified behavior in packages/angular-query-persist-client/package.json: The Angular Vite plugin, Angular common/compiler/core/platform-browser, and Angular Testing Library dev dependencies now use catalog versions instead of their previous explicit version ranges. The Angular animations version and other dependencies in this block are unchanged.
observed — Modified behavior in pnpm-workspace.yaml: The catalog adds the Angular Vite plugin, four Angular 20 packages, and Angular Testing Library; no version entries follow the final dependency.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the Angular package scope and the move to pnpm catalog management.
Description check	✅ Passed	The description explains the catalog changes, lists affected packages, confirms peer dependency and lockfile details, completes the checklist, and identifies the change as dev-only with no release imp…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 0…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-28T09:59:07Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11717

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11717

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11717

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11717

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11717

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11717

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11717

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11717

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11717

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11717

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11717

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11717

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11717

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11717

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11717

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11717

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11717

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11717

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11717

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11717

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11717

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11717

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11717

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11717

commit: 91a311e

github-actions · 2026-09-28T10:00:10Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

chore(angular-query*): manage 'angular' packages with pnpm 'catalog'

91c3a04

sukvvon self-assigned this Sep 28, 2026

sukvvon marked this pull request as draft September 28, 2026 09:58

Merge branch 'main' into chore/catalog-angular

91a311e

sukvvon marked this pull request as ready for review September 28, 2026 16:48

sukvvon merged commit 2aeb5a8 into main Sep 28, 2026
9 checks passed

sukvvon deleted the chore/catalog-angular branch September 28, 2026 17:13

Navigation Menu

Uh oh!

chore(angular-query*): manage 'angular' packages with pnpm 'catalog' - #11717

chore(angular-query*): manage 'angular' packages with pnpm 'catalog'#11717
sukvvon merged 2 commits into
mainfrom
chore/catalog-angular

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 28, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 28, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Architecture Summary

Uh oh!

pkg-pr-new Bot commented Sep 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 28, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 28, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 28, 2026 •

edited

Loading

coderabbitai Bot commented Sep 28, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 28, 2026 •

edited

Loading