test(lit-query/createMutationController): add tests for calling 'mutate' and 'mutateAsync' callbacks when the controller has no callbacks by sukvvon · Pull Request #11760 · TanStack/query

sukvvon · 2026-09-30T15:47:47Z

🎯 Changes

Adds 10 tests to createMutationController.test.ts for callbacks passed to mutate and mutateAsync when the controller options define none:

onSuccess + onSettled and onError + onSettled, for both mutate and mutateAsync
onSuccess, onError, and onSettled alone, for both mutate and mutateAsync

Each test records the callbacks in an array and asserts their order after the sleep(10) mutation settles. The rejected mutateAsync calls are handled with .catch(noop).

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage for per-call success, error, and settled callbacks on mutate and mutateAsync, including individual callback cases when no controller-level callbacks are configured.

…te' and 'mutateAsync' callbacks when the controller has no callbacks

nx-cloud · 2026-09-30T15:48:22Z

View your CI Pipeline Execution ↗ for commit ff2defd

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 20s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 17:08:14 UTC

github-actions · 2026-09-30T15:48:42Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T15:49:59Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 1ec63bd6-0e91-4d10-b52c-c2bfc999351a

📥 Commits

Reviewing files that changed from the base of the PR and between 85138a7 and ff2defd.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 33abe29a-9e16-4a7e-b7dc-5cbe14f90df8

📥 Commits

Reviewing files that changed from the base of the PR and between d374547 and 85138a7.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createMutationController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

The test file adds coverage for per-call onSuccess, onError, and onSettled callbacks when the mutation controller has no configured callbacks.

Changes

Per-call mutation callback coverage

Layer / File(s)	Summary
Callback outcome coverage `packages/lit-query/src/__tests__/createMutationController.test.ts`	Tests cover callback combinations and individual callbacks for successful and rejected mutations through `mutate` and `mutateAsync`.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 85138

This test-only change expands per-call mutation callback coverage. No merge-blocking risk is identified; it is mergeable after normal checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test file and the added coverage for mutate and mutateAsync callbacks when the controller has no callbacks.
Description check	✅ Passed	The description explains the test scope, callback combinations, error handling, checklist status, and release impact. All required template sections are present and complete.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T15:50:12Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11760

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11760

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11760

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11760

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11760

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11760

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11760

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11760

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11760

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11760

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11760

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11760

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11760

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11760

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11760

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11760

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11760

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11760

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11760

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11760

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11760

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11760

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11760

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11760

commit: ff2defd

github-actions · 2026-09-30T15:50:23Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

…-callbacks

test(lit-query/createMutationController): add tests for calling 'muta…

85138a7

…te' and 'mutateAsync' callbacks when the controller has no callbacks

sukvvon self-assigned this Sep 30, 2026

Merge branch 'main' into test/lit-query-create-mutation-controller-no…

ff2defd

…-callbacks

sukvvon merged commit a44dbaf into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-mutation-controller-no-callbacks branch September 30, 2026 17:15

Navigation Menu

Uh oh!

test(lit-query/createMutationController): add tests for calling 'mutate' and 'mutateAsync' callbacks when the controller has no callbacks - #11760

test(lit-query/createMutationController): add tests for calling 'mutate' and 'mutateAsync' callbacks when the controller has no callbacks#11760
sukvvon merged 2 commits into
mainfrom
test/lit-query-create-mutation-controller-no-callbacks

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading