test(lit-query/createQueryController): split combined 'select' and 'refetchOnMount' tests into separate tests by sukvvon · Pull Request #11762 · TanStack/query

sukvvon · 2026-09-30T15:57:50Z

🎯 Changes

Splits two tests in createQueryController.test.ts that each covered two independent cases:

should transform data with select and surface a throwing select as an error becomes:
- should transform data with select
- should surface a throwing select as an error, where select throws from the first fetch instead of after a refetch()
should follow the stale-vs-fresh policy for refetchOnMount, which chained a StaleHost and a FreshHost, becomes:
- should refetch on mount when the data is stale
- should not refetch on mount when the data is fresh, each with a single Host

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded coverage for refetching on remount with stale and fresh data.
- Added separate checks for successful data selection and errors from a failing selector.

…efetchOnMount' tests into separate tests

nx-cloud · 2026-09-30T15:58:17Z

View your CI Pipeline Execution ↗ for commit 5ab8e03

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 9s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 17:08:53 UTC

github-actions · 2026-09-30T15:58:49Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T16:00:07Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 543e31c2-c12d-483d-a322-98e8244b91f0

📥 Commits

Reviewing files that changed from the base of the PR and between 5bee37f and 5ab8e03.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 8a5b390f-6bf5-40eb-a4bf-ba77b7009e38

📥 Commits

Reviewing files that changed from the base of the PR and between d374547 and 5bee37f.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createQueryController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 6 remain after this review.

📝 Walkthrough

Walkthrough

The createQueryController tests now separate stale and fresh data remount cases. They also separate successful selector transformation from selector error handling.

Changes

Query controller tests

Layer / File(s)	Summary
Remount fetch cases `packages/lit-query/src/__tests__/createQueryController.test.ts`	Separate tests verify that a remount refetches data when `staleTime` is `0` and does not refetch when `staleTime` is `Number.POSITIVE_INFINITY`.
Selector result cases `packages/lit-query/src/__tests__/createQueryController.test.ts`	Separate tests verify that `select` transforms `{ value: 2 }` to `20` and that a throwing selector returns an error with message `select-failed`.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5bee3

The test-only change isolates the intended behavior checks. No actionable merge-blocking risk is established; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly and concisely describes the main change: splitting the combined `select` and `refetchOnMount` tests into separate tests.
Description check	✅ Passed	The description includes all required sections. It explains the test changes, completes the checklist, and identifies the change as docs/CI/dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T16:00:22Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11762

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11762

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11762

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11762

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11762

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11762

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11762

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11762

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11762

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11762

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11762

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11762

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11762

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11762

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11762

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11762

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11762

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11762

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11762

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11762

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11762

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11762

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11762

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11762

commit: 5ab8e03

github-actions · 2026-09-30T16:00:31Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

…-select-and-refetch-on-mount

test(lit-query/createQueryController): split combined 'select' and 'r…

5bee37f

…efetchOnMount' tests into separate tests

sukvvon self-assigned this Sep 30, 2026

Merge branch 'main' into test/lit-query-create-query-controller-split…

5ab8e03

…-select-and-refetch-on-mount

sukvvon merged commit 809e9df into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-query-controller-split-select-and-refetch-on-mount branch September 30, 2026 17:17

Navigation Menu

Uh oh!

test(lit-query/createQueryController): split combined 'select' and 'refetchOnMount' tests into separate tests - #11762

test(lit-query/createQueryController): split combined 'select' and 'refetchOnMount' tests into separate tests#11762
sukvvon merged 2 commits into
mainfrom
test/lit-query-create-query-controller-split-select-and-refetch-on-mount

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading