test(lit-query/useMutationState): add test for not processing mutation cache updates while disconnected by sukvvon · Pull Request #11764 · TanStack/query

sukvvon · 2026-09-30T16:00:52Z

🎯 Changes

Adds a test to useMutationState.test.ts. A Host reading the mutation state is connected next to a Producer, then removed. The Producer then runs a mutation. The removed Host must not request another update, which it counts through a requestUpdate override.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage to verify that completing a mutation after its host disconnects does not trigger an additional update.

…n cache updates while disconnected

nx-cloud · 2026-09-30T16:01:18Z

View your CI Pipeline Execution ↗ for commit 7292999

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 2s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 17:10:34 UTC

github-actions · 2026-09-30T16:01:55Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T16:03:20Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

Important

Review skipped

Review was skipped as selected files did not have any reviewable changes.

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: c1fdc65e-2cc7-45a5-a586-f042577ce2de

📥 Commits

Reviewing files that changed from the base of the PR and between af94bc1 and 7292999.

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

🔍 Trigger review

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 2bf9fdb3-5ea4-434d-af4c-529233fd073c

📥 Commits

Reviewing files that changed from the base of the PR and between d374547 and af94bc1.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/useMutationState.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 4 remain after this review.

📝 Walkthrough

Walkthrough

A test was added to verify that a disconnected host does not receive update requests after a producer’s mutation runs.

Changes

Mutation state updates

Layer / File(s)	Summary
Verify updates stop after disconnect `packages/lit-query/src/__tests__/useMutationState.test.ts`	The test records the host’s update-request count after disconnection, runs the producer’s mutation, and checks that the count does not increase.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to af94b

This test-only change adds coverage for mutation updates after host disconnection without changing runtime behavior. No actionable merge-blocking risk is identified.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added test and its purpose: preventing mutation cache updates while disconnected.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the test behavior, records local testing, and identifies the change as having no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T16:03:32Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11764

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11764

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11764

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11764

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11764

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11764

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11764

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11764

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11764

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11764

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11764

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11764

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11764

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11764

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11764

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11764

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11764

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11764

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11764

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11764

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11764

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11764

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11764

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11764

commit: 7292999

github-actions · 2026-09-30T16:03:42Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/useMutationState): add test for not processing mutatio…

af94bc1

…n cache updates while disconnected

sukvvon self-assigned this Sep 30, 2026

Merge branch 'main' into test/lit-query-use-mutation-state-disconnect

7292999

sukvvon merged commit 73f0761 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-use-mutation-state-disconnect branch September 30, 2026 17:20

Navigation Menu

Uh oh!

test(lit-query/useMutationState): add test for not processing mutation cache updates while disconnected - #11764

test(lit-query/useMutationState): add test for not processing mutation cache updates while disconnected#11764
sukvvon merged 2 commits into
mainfrom
test/lit-query-use-mutation-state-disconnect

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Review skipped

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

pkg-pr-new Bot commented Sep 30, 2026 •

edited

Loading