test(lit-query/createMutationController): add test for not processing detached updates when disconnected while in-flight by sukvvon · Pull Request #11770 · TanStack/query

sukvvon · 2026-09-30T18:20:24Z

🎯 Changes

Adds a test to createMutationController.test.ts. The host starts a mutation and is removed before it settles. After the mutation settles, the removed host must not request another update, which it counts through a requestUpdate override.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage for mutations that finish after their host is disconnected, confirming they do not trigger an additional UI update. No user-facing behavior changes are included.

… detached updates when disconnected while in-flight

nx-cloud · 2026-09-30T18:20:49Z

View your CI Pipeline Execution ↗ for commit 6b94f7d

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 16s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 18:23:06 UTC

github-actions · 2026-09-30T18:21:41Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T18:22:04Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 297bc4ef-f18c-42ab-afd1-5868a1aece20

📥 Commits

Reviewing files that changed from the base of the PR and between 73f0761 and 6b94f7d.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createMutationController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 8 remain after this review.

📝 Walkthrough

Walkthrough

Adds a regression test that starts a mutation, disconnects its host while the mutation is in flight, and checks that resolving the mutation does not trigger another requestUpdate.

Changes

Mutation disconnect behavior

Layer / File(s)	Summary
Test mutation completion after disconnection `packages/lit-query/src/__tests__/createMutationController.test.ts`	The test tracks `requestUpdate` calls, disconnects the host while a mutation is in flight, and checks that resolving the mutation does not increase the call count.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 6b94f

This adds coverage for mutation completion after host disconnection without changing runtime behavior. No actionable merge-blocking risk is identified; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added test and the disconnected in-flight mutation behavior it verifies. It is specific and related to the main change, although somewhat long.
Description check	✅ Passed	The description includes all required sections. It explains the test change and motivation, completes the checklist, and identifies the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T18:22:58Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11770

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11770

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11770

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11770

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11770

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11770

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11770

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11770

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11770

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11770

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11770

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11770

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11770

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11770

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11770

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11770

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11770

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11770

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11770

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11770

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11770

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11770

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11770

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11770

commit: 6b94f7d

github-actions · 2026-09-30T18:23:08Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createMutationController): add test for not processing…

6b94f7d

… detached updates when disconnected while in-flight

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit f1ad8d9 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-mutation-controller-disconnect branch September 30, 2026 18:30

Navigation Menu

Uh oh!

test(lit-query/createMutationController): add test for not processing detached updates when disconnected while in-flight - #11770

test(lit-query/createMutationController): add test for not processing detached updates when disconnected while in-flight#11770
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-mutation-controller-disconnect

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading