test(lit-query/createQueriesController): add test for not processing detached updates when disconnected while in-flight by sukvvon · Pull Request #11771 · TanStack/query

sukvvon · 2026-09-30T18:20:28Z

🎯 Changes

Adds a test to createQueriesController.test.ts. The host is removed while its query is still fetching. After the fetch settles, the removed host must not request another update, which it counts through a requestUpdate override.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming that a query completing after its host disconnects does not trigger an additional UI update.

…detached updates when disconnected while in-flight

nx-cloud · 2026-09-30T18:20:53Z

View your CI Pipeline Execution ↗ for commit 5b4091c

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	4m 3s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	1s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 18:25:39 UTC

github-actions · 2026-09-30T18:21:27Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T18:22:43Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 42a6a258-ab19-42c1-bfe7-09a610677df2

📥 Commits

Reviewing files that changed from the base of the PR and between 73f0761 and 5b4091c.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createQueriesController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 7 remain after this review.

📝 Walkthrough

Walkthrough

The change adds a regression test for an in-flight query that completes after its host disconnects. The test checks that completion does not increase the host’s requestUpdate count.

Changes

Lit query update handling

Layer / File(s)	Summary
Verify updates after disconnection `packages/lit-query/src/__tests__/createQueriesController.test.ts`	The test starts a query, disconnects its host before the query resolves, and checks that query completion does not increase the recorded update count.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 5b409

The regression test checks that query completion after host removal requests no additional updates. Production behavior is unchanged, and the change is mergeable subject to normal test checks.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies a test for preventing detached updates after disconnection during an in-flight query. It accurately reflects the main change.
Description check	✅ Passed	The description follows the required template. It explains the test change, completes all checklist items, and identifies the change as dev-only with no release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T18:22:50Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11771

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11771

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11771

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11771

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11771

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11771

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11771

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11771

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11771

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11771

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11771

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11771

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11771

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11771

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11771

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11771

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11771

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11771

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11771

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11771

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11771

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11771

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11771

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11771

commit: 5b4091c

github-actions · 2026-09-30T18:22:58Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

…connect

test(lit-query/createQueriesController): add test for not processing …

5b4091c

…detached updates when disconnected while in-flight

sukvvon self-assigned this Sep 30, 2026

Merge branch 'main' into test/lit-query-create-queries-controller-dis…

baf6bb5

…connect

sukvvon merged commit cfe3aca into main Sep 30, 2026
5 checks passed

sukvvon deleted the test/lit-query-create-queries-controller-disconnect branch September 30, 2026 18:30

Navigation Menu

Uh oh!

test(lit-query/createQueriesController): add test for not processing detached updates when disconnected while in-flight - #11771

test(lit-query/createQueriesController): add test for not processing detached updates when disconnected while in-flight#11771
sukvvon merged 2 commits into
mainfrom
test/lit-query-create-queries-controller-disconnect

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading