test(lit-query/createMutationController): split combined 'mutate'/'mutateAsync' and state transition tests into separate tests by sukvvon · Pull Request #11773 · TanStack/query

sukvvon · 2026-09-30T18:23:09Z

🎯 Changes

Splits two tests in createMutationController.test.ts that each covered two independent flows:

should support mutate and mutateAsync paths becomes:
- should resolve mutateAsync with the mutation data
- should update the result when mutate succeeds
should cover idle/pending/success/error mutation state transitions becomes:
- should transition from idle to pending to success
- should transition from pending to error when the mutation fails

Each test starts from a fresh host. Because the error flow no longer runs after the success flow, it now waits with vi.advanceTimersByTimeAsync(0) before asserting isPending, as the success flow already does.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Expanded coverage for successful mutations, including updates to the mutation result and rendered output.
- Separated error-state checks from success-state transitions and verified rejection behavior for negative inputs.

…tateAsync' and state transition tests into separate tests

nx-cloud · 2026-09-30T18:23:31Z

View your CI Pipeline Execution ↗ for commit 86ce014

Command	Status	Duration	Result
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	1m 12s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 18:25:51 UTC

github-actions · 2026-09-30T18:24:09Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-09-30T18:24:36Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 38efda1f-dbb7-4ec9-ae2c-943936f00dc2

📥 Commits

Reviewing files that changed from the base of the PR and between 73f0761 and 86ce014.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/createMutationController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 5 remain after this review.

📝 Walkthrough

Walkthrough

The mutation controller tests now separate mutateAsync result assertions from mutate state and rendering assertions. They also cover successful and failing mutation transitions in separate tests.

Changes

Mutation controller tests

Layer / File(s)	Summary
Mutation outcomes and state transitions `packages/lit-query/src/__tests__/createMutationController.test.ts`	The tests check the `mutateAsync` result, successful `mutate` data and rendered output, and pending and error states for a rejected mutation.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~10 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to 86ce0

The change separates mutation tests without changing runtime behavior. No actionable merge-blocking risk is identified; merge after normal checks pass.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the test file and the main change: separating combined mutate, mutateAsync, and state-transition tests. It is specific and related to the changeset.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the test changes, reports local testing, confirms policy compliance, and identifies the change as dev…
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-09-30T18:25:43Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11773

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11773

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11773

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11773

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11773

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11773

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11773

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11773

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11773

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11773

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11773

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11773

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11773

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11773

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11773

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11773

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11773

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11773

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11773

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11773

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11773

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11773

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11773

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11773

commit: 86ce014

github-actions · 2026-09-30T18:25:53Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/createMutationController): split combined 'mutate'/'mu…

86ce014

…tateAsync' and state transition tests into separate tests

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit f2032dd into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-create-mutation-controller-split-combined-tests branch September 30, 2026 18:31

Navigation Menu

Uh oh!

test(lit-query/createMutationController): split combined 'mutate'/'mutateAsync' and state transition tests into separate tests - #11773

test(lit-query/createMutationController): split combined 'mutate'/'mutateAsync' and state transition tests into separate tests#11773
sukvvon merged 1 commit into
mainfrom
test/lit-query-create-mutation-controller-split-combined-tests

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading