test(lit-query/{createQueryController,createInfiniteQueryController,createQueriesController}): add tests for returning the same result between reads when nothing changed by sukvvon · Pull Request #11775 · TanStack/query

sukvvon · 2026-09-30T18:38:44Z

🎯 Changes

Adds a test to createQueryController.test.ts, createInfiniteQueryController.test.ts, and createQueriesController.test.ts. After the query settles, reading the accessor twice must return the same result object (toBe) while nothing has changed.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming that repeated reads of infinite, multiple, and single query results return the same object when query state is unchanged.

…reateQueriesController}): add tests for returning the same result between reads when nothing changed

coderabbitai · 2026-09-30T18:39:05Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 37197452-8d5f-4f38-9e19-f679b09bac49

📥 Commits

Reviewing files that changed from the base of the PR and between 8cd151d and b263d40.

📒 Files selected for processing (3)

packages/lit-query/src/__tests__/createInfiniteQueryController.test.ts
packages/lit-query/src/__tests__/createQueriesController.test.ts
packages/lit-query/src/__tests__/createQueryController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 3 remain after this review.

📝 Walkthrough

Walkthrough

Three Lit query controller tests verify that consecutive accessor reads return the same result object when query state remains unchanged.

Changes

Lit query result identity

Layer / File(s)	Summary
Controller accessor identity `packages/lit-query/src/__tests__/createInfiniteQueryController.test.ts`, `packages/lit-query/src/__tests__/createQueriesController.test.ts`, `packages/lit-query/src/__tests__/createQueryController.test.ts`	Added tests that compare consecutive result reads by reference after the initial query fetch.

Priority: ⬇️ Low

Estimated code review effort: 1 (Trivial) | ~5 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to b263d

This PR adds regression tests for stable query-result identity without changing runtime behavior; no actionable merge blocker remains.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the three test files and the main change: verifying stable result identity across reads when query state is unchanged. It is longer than ideal but remains specific and und…
Description check	✅ Passed	The description explains the test changes, states the expected behavior, and includes all template sections. The checklist and release impact fields are completed consistently with a test-only change.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 3…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

nx-cloud · 2026-09-30T18:39:20Z

View your CI Pipeline Execution ↗ for commit b263d40

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	3m 27s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-09-30 18:43:35 UTC

github-actions · 2026-09-30T18:39:51Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

pkg-pr-new · 2026-09-30T18:41:16Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11775

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11775

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11775

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11775

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11775

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11775

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11775

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11775

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11775

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11775

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11775

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11775

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11775

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11775

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11775

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11775

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11775

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11775

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11775

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11775

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11775

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11775

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11775

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11775

commit: b263d40

github-actions · 2026-09-30T18:41:27Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/{createQueryController,createInfiniteQueryController,c…

b263d40

…reateQueriesController}): add tests for returning the same result between reads when nothing changed

sukvvon self-assigned this Sep 30, 2026

sukvvon merged commit 27f8875 into main Sep 30, 2026
9 checks passed

sukvvon deleted the test/lit-query-result-identity branch September 30, 2026 18:55

Navigation Menu

Uh oh!

test(lit-query/{createQueryController,createInfiniteQueryController,createQueriesController}): add tests for returning the same result between reads when nothing changed - #11775

test(lit-query/{createQueryController,createInfiniteQueryController,createQueriesController}): add tests for returning the same result between reads when nothing changed#11775
sukvvon merged 1 commit into
mainfrom
test/lit-query-result-identity

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Sep 30, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

coderabbitai Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

nx-cloud Bot commented Sep 30, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Sep 30, 2026

🚀 Changeset Version Preview

Uh oh!

pkg-pr-new Bot commented Sep 30, 2026

Uh oh!

github-actions Bot commented Sep 30, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Sep 30, 2026 •

edited by coderabbitai Bot

Loading

coderabbitai Bot commented Sep 30, 2026 •

edited

Loading

nx-cloud Bot commented Sep 30, 2026 •

edited

Loading