test(lit-query/BaseController): add test for resolving to a missing client when the host cannot dispatch events by sukvvon · Pull Request #11797 · TanStack/query

sukvvon · 2026-10-01T06:42:42Z

🎯 Changes

Adds "should resolve to a missing client without throwing when the host cannot dispatch events" to BaseController tests.

The client is resolved from a provider through a context event dispatched from the host, but ReactiveControllerHost does not require dispatchEvent. The test connects a controller to a host that only implements ReactiveControllerHost, without an explicit client, and asserts that the controller ends in the missing-client state (connected:missing, then changed:missing, and reading current throws the missing QueryClient error) instead of throwing a TypeError from dispatchEvent.

✅ Checklist

I have followed the steps in the Contributing guide.
I have tested code changes locally with pnpm run test:pr, or these tests do not apply to this pull request.
I have followed the AI contribution policy and fully understand the code in this pull request, including any code generated with AI assistance.

🚀 Release Impact

This change affects published code, and I have generated a changeset.
This change is docs/CI/dev-only (no release).

Summary by CodeRabbit

Tests
- Added coverage confirming that connecting a controller without event-dispatch support does not throw, lifecycle callbacks see no client, and accessing the current value reports a missing client.

…lient when the host cannot dispatch events

nx-cloud · 2026-10-01T06:43:14Z

View your CI Pipeline Execution ↗ for commit e029476

Command	Status	Duration	Result
`nx affected --targets=test:sherif,test:knip,tes...`	✅ Succeeded	2m 46s	View ↗
`nx run-many --target=build --exclude=examples/*...`	✅ Succeeded	2s	View ↗

☁️ Nx Cloud last updated this comment at 2026-10-01 06:46:40 UTC

github-actions · 2026-10-01T06:43:39Z

🚀 Changeset Version Preview

No changeset entries found. Merging this PR will not cause a version bump for any packages.

coderabbitai · 2026-10-01T06:44:11Z

Navigate logical layers of code changes, visualize relationships, and explore their blast radius.

No actionable comments were generated in the recent review. 🎉

ℹ️ Recent review info

⚙️ Run configuration

Configuration used: Repository: TanStack/query/.coderabbit.yaml

Review profile: CHILL

Plan: Advanced

Run ID: 5321a15d-4bd2-438f-8555-1eaaa819df6a

📥 Commits

Reviewing files that changed from the base of the PR and between ea21494 and e029476.

📒 Files selected for processing (1)

packages/lit-query/src/__tests__/BaseController.test.ts

Included review availability: This review used your included allowance. Your plan provides up to 10 included reviews per hour; 9 remain after this review.

📝 Walkthrough

Walkthrough

Adds a BaseController test that connects the controller to a host without event-dispatch methods. The test checks lifecycle client state, the error from accessing current, and controller cleanup.

Changes

BaseController host behavior

Layer / File(s)	Summary
Host behavior test `packages/lit-query/src/__tests__/BaseController.test.ts`	Adds a test that checks lifecycle callbacks observe a missing client, accessing `current` throws the expected `QueryClient` error, and controller cleanup completes.

Priority: ⬇️ Low

Estimated code review effort: 2 (Simple) | ~8 minutes

Change: Other

Merge Risk: ⚪ Minimal · up to e0294

This change adds regression coverage for hosts without event dispatch, with no identified merge-blocking risk.

🚥 Pre-merge checks | ✅ 5

✅ Passed checks (5 passed)

Check name	Status	Explanation
Title check	✅ Passed	The title clearly identifies the added BaseController test and the missing-client behavior when the host cannot dispatch events.
Description check	✅ Passed	The description includes the required Changes, Checklist, and Release Impact sections. It explains the test purpose, validation, checklist completion, and no-release impact.
Docstring Coverage	✅ Passed	No functions found in the changed files to evaluate docstring coverage. Skipping docstring coverage check. Docstring coverage is scoped to functions touched by this diff. Analyzed 0 functions across 1…
Linked Issues check	✅ Passed	Check skipped because no linked issues were found for this pull request.
Out of Scope Changes check	✅ Passed	Check skipped because no linked issues were found for this pull request.

✨ Finishing Touches

📝 Generate docstrings

Commit to this branch
Create a new PR

🧪 Generate unit tests (beta)

Commit to this branch
Create a new PR

Autopilot · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Autopilot is currently an internal CodeRabbit preview.

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

_{Comment @coderabbitai help to get the list of available commands.}

pkg-pr-new · 2026-10-01T06:45:05Z

More templates

@tanstack/angular-query-experimental

npm i https://pkg.pr.new/@tanstack/angular-query-experimental@11797

@tanstack/eslint-plugin-query

npm i https://pkg.pr.new/@tanstack/eslint-plugin-query@11797

@tanstack/lit-query

npm i https://pkg.pr.new/@tanstack/lit-query@11797

@tanstack/preact-query

npm i https://pkg.pr.new/@tanstack/preact-query@11797

@tanstack/preact-query-devtools

npm i https://pkg.pr.new/@tanstack/preact-query-devtools@11797

@tanstack/preact-query-persist-client

npm i https://pkg.pr.new/@tanstack/preact-query-persist-client@11797

@tanstack/query-async-storage-persister

npm i https://pkg.pr.new/@tanstack/query-async-storage-persister@11797

@tanstack/query-broadcast-client-experimental

npm i https://pkg.pr.new/@tanstack/query-broadcast-client-experimental@11797

@tanstack/query-core

npm i https://pkg.pr.new/@tanstack/query-core@11797

@tanstack/query-devtools

npm i https://pkg.pr.new/@tanstack/query-devtools@11797

@tanstack/query-persist-client-core

npm i https://pkg.pr.new/@tanstack/query-persist-client-core@11797

@tanstack/query-sync-storage-persister

npm i https://pkg.pr.new/@tanstack/query-sync-storage-persister@11797

@tanstack/react-query

npm i https://pkg.pr.new/@tanstack/react-query@11797

@tanstack/react-query-devtools

npm i https://pkg.pr.new/@tanstack/react-query-devtools@11797

@tanstack/react-query-next-experimental

npm i https://pkg.pr.new/@tanstack/react-query-next-experimental@11797

@tanstack/react-query-persist-client

npm i https://pkg.pr.new/@tanstack/react-query-persist-client@11797

@tanstack/solid-query

npm i https://pkg.pr.new/@tanstack/solid-query@11797

@tanstack/solid-query-devtools

npm i https://pkg.pr.new/@tanstack/solid-query-devtools@11797

@tanstack/solid-query-persist-client

npm i https://pkg.pr.new/@tanstack/solid-query-persist-client@11797

@tanstack/svelte-query

npm i https://pkg.pr.new/@tanstack/svelte-query@11797

@tanstack/svelte-query-devtools

npm i https://pkg.pr.new/@tanstack/svelte-query-devtools@11797

@tanstack/svelte-query-persist-client

npm i https://pkg.pr.new/@tanstack/svelte-query-persist-client@11797

@tanstack/vue-query

npm i https://pkg.pr.new/@tanstack/vue-query@11797

@tanstack/vue-query-devtools

npm i https://pkg.pr.new/@tanstack/vue-query-devtools@11797

commit: e029476

github-actions · 2026-10-01T06:45:15Z

size-limit report 📦

Path	Size
react full	11.73 KB (0%)
react minimal	8.58 KB (0%)

test(lit-query/BaseController): add test for resolving to a missing c…

e029476

…lient when the host cannot dispatch events

sukvvon self-assigned this Oct 1, 2026

sukvvon merged commit 782b2e6 into main Oct 1, 2026
9 checks passed

sukvvon deleted the test/lit-query-base-controller-non-element-host branch October 1, 2026 07:09

Navigation Menu

Uh oh!

test(lit-query/BaseController): add test for resolving to a missing client when the host cannot dispatch events - #11797

test(lit-query/BaseController): add test for resolving to a missing client when the host cannot dispatch events#11797
sukvvon merged 1 commit into
mainfrom
test/lit-query-base-controller-non-element-host

sukvvon commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

Uh oh!

nx-cloud Bot commented Oct 1, 2026 •

edited

Loading

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

Uh oh!

Conversation

sukvvon commented Oct 1, 2026 • edited by coderabbitai Bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

🎯 Changes

✅ Checklist

🚀 Release Impact

Summary by CodeRabbit

Uh oh!

nx-cloud Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

github-actions Bot commented Oct 1, 2026

🚀 Changeset Version Preview

Uh oh!

coderabbitai Bot commented Oct 1, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Walkthrough

Changes

Uh oh!

pkg-pr-new Bot commented Oct 1, 2026

Uh oh!

github-actions Bot commented Oct 1, 2026

size-limit report 📦

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

1 participant

sukvvon commented Oct 1, 2026 •

edited by coderabbitai Bot

Loading

nx-cloud Bot commented Oct 1, 2026 •

edited

Loading

coderabbitai Bot commented Oct 1, 2026 •

edited

Loading