Skip to content

@tanstack/react-router: authored agent skills are never published — package.json#files excludes skills/ #8738

Closed

Description

@MAST1999

Which project does this relate to?

Router

Describe the bug

packages/react-router/skills/ is authored and actively maintained on main (skills react-router, compositions, lifecycle — last touched 2026-10-06 in df8bbf2, "docs: use queryClient.query() in guides and agent skills"), but the published npm package never contains it: packages/react-router/package.json#files is ["dist", "src"], so skills/ is excluded from every release.

Agent tooling that discovers skills from installed packages (e.g. @tanstack/intent) therefore can never see react-router's skills, at any version. The sibling package @tanstack/router-core ships its skills/ directory correctly (11 entries in 1.171.38), so the react-router omission looks unintentional rather than a deliberate split.

Complete minimal reproducer

https://github.com/MAST1999/tanstack-router-skills-repro

Steps to Reproduce the Bug

  1. npm install @tanstack/react-router (any recent version; reproduced on 1.170.45, the current latest)
  2. ls node_modules/@tanstack/react-router/skills → the directory does not exist
  3. curl -sL https://registry.npmjs.org/@tanstack/react-router/-/react-router-1.170.45.tgz | tar tzf - | grep -c 'skills/' → 0
  4. Contrast: ls node_modules/@tanstack/router-core/skills → 10+ SKILL.md files present

Expected behavior

skills/ is included in the published @tanstack/react-router tarball, matching @tanstack/router-core — i.e. add "skills" to files:

   "files": [
     "dist",
-    "src"
+    "src",
+    "skills"
   ],

(The repro repo's mock-pack/ proves this with npm pack on a stub carrying the exact files field: 0 skills/ entries before, 3 after.)

Screenshots or Videos

No response

Platform

Packaging — not runtime. Reproduced with @tanstack/react-router@1.170.45 (npm latest as of 2026-10-17).

Additional context

  • Discovered while wiring @tanstack/intent in a downstream repo: @tanstack/react-router is declared in its intent.skills allowlist but never discovers, because the skills never reach node_modules.
  • @tanstack/router-core demonstrates the intended shipping behavior.
  • Happy to open the one-line PR (with a changeset) if maintainers agree this is unintended.

Activity

  1. Sheraff commented on Oct 17, 2026

    @Sheraff
    Collaborator
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

      Milestone

      No milestone

      Relationships

      None yet

      Development

      No branches or pull requests

      Issue actions