fix(start): omit build paths from production manifests - #8432
danieljvdm wants to merge 1 commit into
Conversation
|
Validated against main
The source and dependency inputs are unchanged since those checks. No performance improvement is claimed. |
|
No actionable comments were generated in the recent review. 🎉 ℹ️ Recent review info⚙️ Run configurationConfiguration used: Path: .coderabbit.yaml Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (3)
Included review availability: Your plan provides up to 10 included reviews per hour; 9 remain after this review. 📝 WalkthroughWalkthroughThe production Start manifest no longer includes build-only route file paths. A regression test confirms identical output across checkout paths, preserves frozen route inputs, and verifies emitted assets. A patch changeset documents the update. ChangesProduction manifest path pruning
Priority: ⬇️ Low Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Merge Risk: ⚪ Minimal · up to The production manifest removes build-only checkout paths without affecting the assets used to render routes. No merge-blocking risk remains. 🚥 Pre-merge checks | ✅ 4 | ❌ 1❌ Failed checks (1 warning)
✅ Passed checks (4 passed)
Full details: Docstring CoverageExplanation Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 1 functions across 2 files. (1 skipped: 1 unsupported.)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
🎯 Changes
Production Start manifests embed absolute route source paths, so moving an unchanged project changes the emitted JavaScript. Remove those build-only paths after client chunk lookup, preserving the original route metadata for build and development use and leaving the general serializer unchanged.
Related to #4469; the absolute lookup paths were introduced in #4453.
✅ Checklist
🚀 Release Impact
Summary by CodeRabbit
Bug Fixes
Release