Conversation
|
Important Review skippedAuto reviews are disabled on base/target branches other than the default branch. Please check the settings in the CodeRabbit UI or the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
ReviewIntent: Fix #8241 — SSR rendered route Verdict: Approach looks right and matches the bug. No hard blockers from the diff; I’d want maintainer CI (or a green run on BlockersNone in the code itself. Should confirm
Nits
What’s strong
|
|
View your CI Pipeline Execution ↗ for commit 75a7ac8
☁️ Nx Cloud last updated this comment at |
Hooray! CodSpeed harness just leveled up!The base and head of this comparison were measured with different runner settings, so their benchmark values are not directly comparable. What changed between base and head:
Re-run the base with the same settings to get a valid performance comparison. Comparing Footnotes |
What
CatchBoundaryWhy
During SSR,
MatchInnerrendered a routeerrorComponentinline, while the client threw the same error intoCatchBoundary. Solid assigns hydration IDs from the owner tree, so the client could not claim the server-rendered error UI and its controls remained unwired.Rendering known route errors from one stable boundary position keeps the server and client owner trees aligned.
Fixes #8241
Tests
cd packages/solid-router && pnpm run test:unit(873 passed, 2 skipped; server mode: 7 passed)cd packages/solid-router && pnpm run test:types(TypeScript 5.6 through 7.0)cd packages/solid-router && pnpm run test:eslint(0 errors; 33 existing warnings)cd packages/solid-router && pnpm run buildcd e2e/solid-start/query-integration && pnpm run builderror-component-hydration.spec.tsandnot-found-reload.spec.ts(4 passed)Checklist