You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
No actionable comments were generated in the recent review. 🎉
ℹ️ Recent review info
⚙️ Run configuration
Configuration used: defaults
Review profile: CHILL
Plan: Advanced
Run ID: 186a79bf-cffe-4903-a280-264cd2827af9
📥 Commits
Reviewing files that changed from the base of the PR and between 871945d and 3fcb049.
📒 Files selected for processing: 2
src/routeTree.gen.ts
tests/docs-route-smoke.test.ts
Included review availability: This review used your included allowance. Your plan provides up to 4 included reviews per hour; 3 remain after this review.
📝 Walkthrough
Adds a versioned Markdown bundle-size report route, registers it in the generated route tree, renders the report with library metadata, and adds route smoke coverage. The screen-reader-only Markdown link now renders only when pagePath is provided.
Changes: Markdown bundle-size report
Layer / File(s)
Summary
Load and render the bundle-size report src/routes/_library/markdown.$version.reports.sizes.tsx
The route loads version-specific configuration and report content in parallel. It sets SEO metadata and cache headers, then renders the report with library metadata.
Register and smoke-test the report route src/routeTree.gen.ts, tests/docs-route-smoke.test.ts
The generated route tree registers /markdown/$version/reports/sizes under the library route. The smoke test includes /markdown/latest/reports/sizes with an expected successful outcome.
The versioned report route points to the existing bundle-size report, and the smoke test checks for a successful response. No concrete merge-blocking issue was established; the deployed route was not checked.
Pre-merge checks: 4 · 1
Failed checks: 1 warning
Check name
Status
Explanation
Resolution
Docstring Coverage
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff. Analyzed 2 functions across 4 files.
Write docstrings for the functions missing them to satisfy the coverage threshold.
Passed checks: 4 passed
Check name
Status
Explanation
Description Check
Check skipped - CodeRabbit’s high-level summary is enabled.
Title check
The title clearly describes the main change: adding a Markdown bundle-size report route.
Linked Issues check
Issue [#1195] requires the Markdown bundle report link to reach /markdown/latest/reports/sizes instead of a 404. The PR registers /markdown/$version/reports/sizes, loads reports/sizes.md for the…
Out of Scope Changes check
The changes stay within the stated issue scope. The route implementation and generated route registration provide the missing report endpoint. The smoke test verifies the endpoint. The conditional `Do…
Fix all pre-merge checks with AI
✨ Finishing Touches
🧪 Generate unit tests (beta)
Create a new PR
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.
Thanks for the fix! I merged current main into this branch and regenerated the route tree to resolve the conflict, preserving your implementation.
pnpm test passes. I also checked the local HTTP responses: /markdown/latest/reports/sizes and /markdown/v1/reports/sizes both return 200 and render the bundle-size table. An invalid version redirects to /markdown/latest with 308. The isolated new route module measures 1,439 minified bytes / 734 gzip bytes with imports external, not a full production bundle measurement.
Checks are starting on 3fcb049e545c652651d698cb065c4c1aea3da3b6. I'll wait for those before merging, then check the deployed report before closing #1195.
This branch has not been deployed
No deployments
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Verification
Closes #1195
Summary by CodeRabbit
New Features
Bug Fixes
Tests