Repository navigation
Restore original Scarf tracking alongside namethathost - #1250
Merged
Merged
Conversation
|
Caution Review failedThe pull request is closed. ℹ️ Recent review info⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: 📒 Files selected for processing (5)
📝 WalkthroughWalkthroughThe change adds optional Scarf identifiers to library metadata, validates their UUID format, introduces a mounted tracking image, and renders it for library routes that define an identifier. ChangesScarf analytics tracking
Estimated code review effort: 2 (Simple) | ~10 minutes Change: Bug fix Sequence Diagram(s)sequenceDiagram
participant RouteForm
participant Scarf
participant RouterState
participant ScarfEndpoint
RouteForm->>Scarf: Render with scarfId
Scarf->>RouterState: Read locationKey
Scarf->>ScarfEndpoint: Request tracking image
Suggested reviewers: ✨ Finishing Touches📝 Generate docstrings
🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Restores the original Scarf component, all ten library pixel IDs, library route integration, and the existing ID validation test exactly as they were before removal. Scarf runs alongside namethathost so company attribution can be compared.
Validation: restored files match the pre-removal commit byte for byte.
pnpm testpassed (501 passed, one skipped), andpnpm buildpassed. The privacy policy and namethathost integration are unchanged.Summary by CodeRabbit
New Features
Tests