Skip to content

Return 404 for missing framework documentation - #1257

Merged
tannerlinsley merged 1 commit into
mainfrom
taren/seo-docs-not-found
Sep 11, 2026
Merged

tannerlinsley merged 1 commit into
mainfrom
taren/seo-docs-not-found

Conversation

@tannerlinsley

Copy link
Copy Markdown
Member

Unknown framework documentation URLs currently redirect to a generic documentation index that returns 200. Return the existing not-found response instead, so missing pages produce HTTP 404 and readers can recover through the existing navigation. Explicit redirects for moved documents are preserved.

Validation:

  • pnpm test passes: type checks, lint, and 510 unit tests (3 environment-dependent tests skipped).
  • Ran the new HTTP smoke test against the local site for both React and Solid: direct 404, no Location header, and the existing not-found content.
  • Verified the rendered page, recovery link to Start docs, and browser back navigation.

@coderabbitai

coderabbitai Bot commented Sep 11, 2026

Copy link
Copy Markdown

Warning

Review limit reached

Next included review available in 34 minutes.

Check out review usage here.

View limit details

Limit details: You’ve used all 4 included reviews currently available.

You've used all free OSS reviews for now. Wait for the free limit to reset to keep reviewing this public repository.

Learn how review limits work.

Review configuration:

⚙️ Run configuration

Configuration used: defaults

Review profile: CHILL

Plan: Advanced

Run ID: b885aaba-ba6b-4f8e-901e-6510c1bcd5aa

📥 Commits

Reviewing files that changed from the base of the PR and between 88723b5 and 6cbc7a5.

📒 Files selected for processing (2)
  • src/routes/_library/$libraryId/$version.docs.framework.$framework.$.tsx
  • tests/docs-route-smoke.test.ts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@cloudflare-workers-and-pages

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 6cbc7a5 Commit Preview URL

Branch Preview URL
Sep 11 2026, 08:21 PM

@tannerlinsley
tannerlinsley merged commit 2ba569a into main Sep 11, 2026
7 checks passed
@tannerlinsley
tannerlinsley deleted the taren/seo-docs-not-found branch September 11, 2026 20:24
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant