Repository navigation
fix(docs): Prevent examples index page crash - #1292
sentry[bot] wants to merge 1 commit into
Conversation
|
Important Review skippedBot user detected. To trigger a single review, invoke the ⚙️ Run configurationConfiguration used: defaults Review profile: CHILL Plan: Advanced Run ID: You can disable this status message by setting the Use the checkbox below for a quick retry:
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 61c00a2 | Commit Preview URL Branch Preview URL |
Sep 23 2026, 11:05 PM |
|
Closing this in favor of #1197, which merged on October 12 and fixes all three example path constructions by omitting an absent slug. That preserves the examples index instead of returning a 404 for it. I verified those three fixes are present in the current source, and |
When navigating to an examples index page (e.g.,
/table/latest/docs/framework/react/examples) without a specific example slug,params._splatisundefined.Previously, this would cause
[framework, params._splat].join('/')to produce a path with a trailing slash (e.g.,react/). This malformed path was then rejected byisValidRepoPathduring validation, leading to a page crash.This fix addresses the issue by:
src/routes/_library/$libraryId/$version.docs.framework.$framework.examples.$.tsx), explicitly checking for an undefinedparams._splatand throwingnotFound()early. This prevents the construction of an invalidrepoStartingDirPathand ensures a graceful 404 for index pages.examplePathconstruction in two other locations within the same file (lines 352 and 613) to ensure that if_splatis ever undefined in those contexts, a trailing slash is not inadvertently created. This provides additional robustness.Fixes TANSTACK-COM-545
@sentry <feedback>: Autofix iterates on these changes@sentry stop iterating: Autofix stops iterating on this runThis PR was automatically generated by Sentry. You can adjust this setting at any time.