Skip to content

fix(sentry): stop reporting expected notFound/redirect as errors - #1310

Open
sentry[bot] wants to merge 3 commits into
mainfrom
seer/fix/sentry-control-flow-errors
Open

sentry[bot] wants to merge 3 commits into
mainfrom
seer/fix/sentry-control-flow-errors

Conversation

@sentry

@sentry sentry Bot commented Sep 30, 2026 •

Copy link
Copy Markdown
Contributor

Filter expected Router notFound and redirect signals from Sentry while keeping real errors reportable. Uses Router’s isNotFound/isRedirect guards, including actual redirect Response values, and preserves the existing BYOK/privacy redaction, stale-page recovery and third-party script filters.

AI review notes:
Updated against main 710d2b0 with head 9382fa5. Full pnpm test passed in an isolated checkout: type checks, lint, 713 unit tests (5 skipped), 2,278 chat tests (6 skipped), and 20 desktop tests (1 skipped). Regression coverage uses actual notFound/redirect values and keeps ordinary errors, HTTP 500 responses and misleading plain objects reportable.
Required CI and Website Maintainers review must pass before merge. Preview deployment succeeded; this is not yet merged or verified in production.

Fixes TANSTACK-COM-4QS

Originally generated by Sentry, updated through repository maintenance.

@sentry
sentry Bot requested a review from a team September 30, 2026 11:01
@coderabbitai

coderabbitai Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Important

Review skipped

Bot user detected.

To trigger a single review, invoke the @coderabbitai review command.

Run configuration
  • Source mode: Auto
  • Repository: Unavailable
  • Branch: Unavailable
  • File: No configuration file from this repository applied
  • Commit: Unavailable
  • Layers: defaults
  • Review profile: CHILL
  • Plan: Advanced
  • Run ID: 7b3c6432-e550-4d52-b162-546d2380041b

You can disable this status message by setting the reviews.review_status to false in the CodeRabbit configuration file.

Use the checkbox below for a quick retry:

  • Trigger review
  • Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts

Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

Share

@cloudflare-workers-and-pages

cloudflare-workers-and-pages Bot commented Sep 30, 2026 •

Copy link
Copy Markdown

Deploying with  Cloudflare Workers  Cloudflare Workers

The latest updates on your project. Learn more about integrating Git with Workers.

Status Name Latest Commit Preview URL Updated (UTC)
✅ Deployment successful!
View logs
tanstack-com 9382fa5 Commit Preview URL

Branch Preview URL
Nov 04 2026, 02:09 AM

@changeset-bot

changeset-bot Bot commented Oct 14, 2026 •

Copy link
Copy Markdown

⚠️ No Changeset found

Latest commit: 9382fa5

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

@tannerlinsley

Copy link
Copy Markdown
Member

Updated this against current main and replaced the property checks with Router’s isNotFound/isRedirect helpers. An actual redirect() result is a Response with options, so the old isRedirect === true check missed it. The regression uses real notFound()/redirect() values, keeps ordinary errors and HTTP 500 responses reportable, and checks that BYOK headers are still removed. Current server initialization settings are preserved. The full pnpm test suite and commit hooks passed: 550 unit tests passed with 4 skipped, 2269 chat tests passed, and 20 desktop tests passed with 1 skipped, plus type and lint checks. New CI is running on 3c6e2b5. The server instrumentation change still needs the required team review before merge.

@tannerlinsley

Copy link
Copy Markdown
Member

Updated this against current main so the Sentry fix can move forward without losing the newer privacy and stale-page recovery behavior. The required maintainer review still applies.

AI review notes:
Resolved the conflicts in server instrumentation and router initialization. The server still removes Scarf lookup breadcrumbs and redacts transaction headers. The browser still suppresses the exact error that triggered stale-page recovery, and keeps later failures reportable. Router notFound and redirect values remain filtered through the actual Router guards.
Full pnpm test passed in an isolated checkout with an empty environment: type checks, lint, 713 unit tests (5 skipped), 2,278 chat tests (6 skipped), and 20 desktop tests (1 skipped). Updated head: 9382fa5. New CI and required Website Maintainers review remain before merge.

This branch has not been deployed

No deployments
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant