Skip to content

fix: hide unavailable library Discussions links #1374

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tannerlinsley merged 1 commit into from
Oct 13, 2026
Merged

fix: hide unavailable library Discussions links #1374

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions src/libraries/libraries.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -343,6 +343,7 @@ export const charts: LibrarySlim = {
description:
'A typed, tree-shakable chart grammar for SVG and Canvas. Compose marks, views, scales, transforms, interactions, and motion with compact primitives or D3-compatible inputs.',
repo: 'tanstack/charts',
hasDiscussions: false,
frameworks: [
'react',
'preact',
Expand Down Expand Up @@ -635,6 +636,7 @@ export const markdown: LibrarySlim = {
colorTo: 'to-fuchsia-500',
bgRadial: 'from-fuchsia-500 via-fuchsia-500/50 to-transparent',
repo: 'tanstack/markdown',
hasDiscussions: false,
frameworks: ['react', 'vanilla'],
corePackageName: '@tanstack/markdown',
npmPackageNames: ['@tanstack/markdown'],
Expand Down
1 change: 1 addition & 0 deletions src/libraries/types.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -40,6 +40,7 @@ export type LibrarySlim = {
bgRadial?: string
badge?: 'new' | 'soon' | 'alpha' | 'beta' | 'fresh' | 'RC'
repo: string
hasDiscussions?: boolean
frameworks: Framework[]
latestVersion: string
latestBranch?: string
Expand Down
20 changes: 11 additions & 9 deletions src/routes/_library/$libraryId/$version.docs.framework.index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -84,15 +84,17 @@ function RouteComponent() {
<DiscordIcon className="w-5 h-5" />
Join Discord
</a>
<a
href={`https://github.com/${library.repo}/discussions`}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center gap-2 px-6 py-3 bg-gray-900 dark:bg-gray-100 text-white dark:text-gray-900 rounded-lg hover:bg-gray-800 dark:hover:bg-gray-200 transition-colors"
>
<GithubIcon className="w-5 h-5" />
Start Discussion
</a>
{library.hasDiscussions !== false && (
<a
href={`https://github.com/${library.repo}/discussions`}
target="_blank"
rel="noopener noreferrer"
className="inline-flex items-center gap-2 px-6 py-3 bg-gray-900 dark:bg-gray-100 text-white dark:text-gray-900 rounded-lg hover:bg-gray-800 dark:hover:bg-gray-200 transition-colors"
>
<GithubIcon className="w-5 h-5" />
Start Discussion
</a>
)}
</div>
</div>
</Card>
Expand Down
Loading