Repository navigation
Fix current-page state on breadcrumb ancestors - #1462
Conversation
|
|
No actionable comments were generated in the recent review.
|
| Layer / File(s) | Summary |
|---|---|
Set exact route matching src/components/Breadcrumbs.tsx |
Breadcrumb item links set activeOptions={{ exact: true }}. |
Estimated code review effort: 1 (Trivial) | ~3 minutes
Change: Bug fix · Severity of issue fixed: Low
Possibly related PRs
- TanStack/tanstack.com#1461: Adds optional breadcrumb items in the same component; this change follows it by setting exact route matching.
Suggested reviewers: ladybluenotes
Merge Risk: 
Minimal · up to 5d34f
-
The breadcrumb change addresses duplicate current-page matching without an identified regression or merge-blocking risk.
Pre-merge checks: 
4 · 
1
-
Failed checks: 1 warning Passed checks: 4 passedFull details: Docstring Coverage
-
Explanation
Docstring coverage is 0.00% which is insufficient. The required threshold is 80.00%. Docstring coverage is scoped to functions touched by this diff with cyclomatic complexity of at least 2. Documentation-only edits and deletions within surviving functions are included; unchanged diff context and fully deleted functions are excluded. Analyzed 1 functions across 1 files.
Resolution
Write docstrings for the functions missing them to satisfy the coverage threshold.
-
Finishing Touches
-
Generate docstrings
-
- Commit to this branch
- Create a new PR
Generate unit tests (beta)
-
- Commit to this branch
- Create a new PR
-
- Autofix · Keep fixing CodeRabbit findings and required CI, and resolving merge conflicts
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.
Deploying with
|
| Status | Name | Latest Commit | Preview URL | Updated (UTC) |
|---|---|---|---|---|
| ✅ Deployment successful! View logs |
tanstack-com | 5d34f53 | Commit Preview URL Branch Preview URL |
Nov 01 2026, 12:11 AM |
On blog articles, the Blog ancestor link matched the current URL by prefix, so both Blog and the article were announced as the current page. Use exact route matching for breadcrumb ancestors so only the terminal article has
aria-current="page".Verified the defect in production HTML and the hydrated DOM. An isolated SSR fixture using the installed RouterProvider and actual Breadcrumbs component fails against the previous behavior with two current-page markers and passes with one after this change.
pnpm testpassed. Follow-up to #1461, related to #1151.Summary by CodeRabbit