fix(windows): preserve pipe continuity and verify process liveness - #191
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Fix two Windows daemon issues:
NotFound.WaitForSingleObjectcall. Successfully opening a process handle alone does not prove the process is still running.Add five Windows regression tests covering pipe handoff, rapid disconnects, concurrent RPC connections, and process liveness, including exited processes with retained handles and exit code 259. Add a Windows CI job for these tests.
Validation
Related to #181. The original session-loss scenario was not reproduced locally, so this change does not claim to resolve all symptoms reported in that issue.