Repository navigation
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Runner capability checks currently reject valid versions such as
0.8.0+internal, and the default-machine page describes unparseable versions such asdevas an older release. Custom builds consequently lose capabilities despite retaining the release's version.Use
golang.org/x/mod/semverfor backend capability comparisons and mirror its precedence in the existing browser selector. Build metadata is ignored, prereleases sort below their corresponding release, and existing numericv1/v1.2shorthand remains accepted. Unknown or malformed versions continue to disable gated capabilities, with a distinct “cannot determine compatibility” default-selection message. Document these rules for custom deployments.Refs #1074. This addresses the runner comparison/default-selection portion only; platform build metadata/UI, schema tracking, and cross-component protocol contracts remain separate work.
Validation:
go test ./internal/domainandgo vet ./internal/domainpassed.node web/runner_default_rule_test.jspassed; four MCP/SOP/runner view tests passed, including rendered default-button eligibility and reasons.node --check web/app/runners.js,git diff --check, and the public-content checker on the materialized sparse checkout passed.Full platform builds, full-repository tests and a live runner deployment were not run. The new direct x/mod dependency requires Go 1.26.0; this repository already specifies Go 1.26.11. Custom protocol changes still require their own compatibility verification.