Skip to content

feat(runner): distribute platform SSH host keys - #1131

Open
crispinhu27 wants to merge 3 commits into
mainfrom
feature/runner-ssh-known-hosts
Open

crispinhu27 wants to merge 3 commits into
mainfrom
feature/runner-ssh-known-hosts

Conversation

@crispinhu27

Copy link
Copy Markdown
Collaborator

What changed

Runners previously needed a local known_hosts file to clone from a self-managed Git host. Operators can now configure AGENTFLOW_GIT_SSH_KNOWN_HOSTS once on the platform for Git operations executed by runners.

  • Send entries that match the SSH hostname and port over the authenticated runner claim and workspace control paths.
  • Apply the platform entries for the matching endpoint. Runner-local entries cover other endpoints. OpenSSH continues to verify host keys strictly and honor revocations.
  • Verify the authenticated claim and a real clone from a loopback SSH server with the runner-local variable empty.

Scope

  • Platform core / API / runner
  • Shared behavior contract

Compatibility

Deploy the updated platform and Runner 0.11.1 to enable platform-only configuration. Older runners continue to read their local file. A worker that connects to the Git host directly reads its own configuration.

Validation

  • The rebased commit passed go test -p=4 ./internal/gitwork ./internal/httpapi ./internal/runner ./internal/runtime ./internal/engine ./internal/domain ./internal/repo -run 'SSH|GitHTTP|RunnerWorkspace|DockerRunnerHelper' -count=1 -timeout=3m.
  • go vet -p=4 ./..., python3 scripts/check-public.py, and git diff --check origin/main...HEAD passed.
  • Before rebasing, the chatbot build and tests passed, and the SSH regression suite passed in Linux Docker. The full Linux Docker run reached the engine test timeout and had failures in runtime fixtures.

Safety

  • Public changes use synthetic test inputs and example domains.
  • Changes are isolated to the feature worktree.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant