Repository navigation
fix(events): add exclude_markets to events.get (Closes #542) - #543
Merged
Merged
Conversation
Sync OpenAPI GetEvent optional query param exclude_markets and expose it on sync/async EventsResource.get. Additive optional — no migration note.
Merged
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Reconciles nightly Spec Drift Detection failure (#542): upstream
GET /events/{event_ticker}gained optional boolean query paramexclude_markets.specs/openapi.yaml(OpenAPI still 3.34.0; only GetEvent params changed)exclude_markets: bool | None = Noneto sync + asyncEventsResource.get, serialized via_bool_param(same pattern aswith_nested_markets)Additive optional — non-breaking. No SemVer bump in this PR (will ship in the pending 22.0.0 release that also covers #540/#541).
Closes #542.
Test plan
uv run ruff check .uv run mypy kalshi/uv run pytest tests/ --ignore=tests/integration -q(4696 passed)