Repository navigation
fix: reconcile spec drift #556 #557 (22.4.0) - #558
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Reconciles nightly spec drift (Spec Drift run 40320006492). Release 22.4.0 (minor).
Closes #556
Closes #557
Changes
scripts/sync_spec.py+scripts/generate.py(re-vendoredspecs/openapi.yaml,specs/asyncapi.yaml,specs/perps_openapi.yaml; no hand edits inkalshi/_generated).CreateRFQBatchChild: optionalcontracts(contracts_fp, FixedPointCount) andtarget_cost(target_cost_dollars, DollarDecimal) withserialization_alias+AliasChoices, matchingCreateRFQBatchRequest.MarginMarket.halt_sources: list[str] | None = None. Spec marks it required; kept optional (PERPS_EXCLUSIONS entry, kindserver_omits_despite_required) so this stays non-breaking.batch_communicationsremoved; RFQ-batch messages now arrive oncommunications. The SDK never exposed a helper/model for it, so nothing was removed; notes added onsubscribe_communications(),CommunicationsMessage,docs/websockets.md.Blast radius (manual; GitNexus unavailable)
CreateRFQBatchChild: new optional fields defaultNoneand are excluded when unset → existingrfq_batches.create()payloads serialize identically. Used only bycommunications.rfq_batches.create(sync + async).MarginMarket: new optional field; existing constructors/fixtures and payloads without it still validate. Consumers: perpsmarkets.list/getand anything embeddingMarginMarket.Gates
uv run ruff check .✅uv run mypy kalshi/✅uv run pytest tests/ --ignore=tests/integration -q✅ 4935 passed, 3 skippeduv run pytest tests/test_contracts.py -W error::UserWarning✅ 902 passed