Repository navigation
feat(perps): is_block_trade on margin trades; Klear report types (#567) — 22.7.0 - #568
Merged
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #567
Spec drift (run 41644653360): perps
GET /margin/tradesgainedis_block_tradequery param;MarginTrade/ WSmarginTradePayloadgainedis_block_trade; Klearreport_typeenum gained*_fpvariants. Release 22.7.0 (additive, optional).Changes
perps.portfolio.trades/trades_all(sync + async): keyword-onlyis_block_trade: bool | None = None, sent as"true"/"false"only when not None.MarginTrade.is_block_trade,MarginTradePayload.is_block_trade: optionalbool | None(spec-required →PERPS_EXCLUSIONSserver_omits_despite_required).MarginReportTypeLiteral: full spec enum (adds*_fpvariants plus previously missing base types incl.daily_statement).kalshi/_generatedunchanged in effect. Version 22.7.0, CHANGELOG, docs/perps.md.Blast radius (hand-written; GitNexus unavailable)
_margin_trades_paramsis used only by the 4 perps trades methods; new param defaults to None → identical query for existing callers.extra="allow"already present → no parsing change for existing payloads.Gates
ruff pass · mypy pass · 5072 passed/3 skipped · contracts strict 930 passed