Repository navigation
fix(typing): normalize polars aggregates for polars 1.44 (unblocks #154) - #157
Merged
Merged
Conversation
Polars 1.44 types Series.sum() as int | float | Decimal, so mypy rejects arithmetic on VWAP and orderbook imbalance. Convert aggregates to float/int at the read site. Runtime return values are unchanged.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Unblocks Dependabot #154 (python-patch group), whose CI
lintjob fails only on mypy after its polars 1.32.2 → 1.44.2 bump. Polars 1.44 typesSeries.sum()asint | float | Decimal, which produced 11 operator/TypedDict errors in:sessions/statistics.py(VWAP)client/market_data.py(session VWAP)orderbook/base.py(bid/ask totals and imbalance)The fix converts the aggregates to
float/intwhere they're read. Runtime return values are unchanged (orderbookvolumeisInt64; empty/zero handling is the same). There's no# type: ignoreand no public API change. Unit tests pin VWAP, session VWAP, and orderbook totals/imbalance, including empty sides.The branch is code-only and doesn't touch
uv.lock; Dependabot owns the lock. I checked mypy locally against both polars 1.32.2 (the current lock) and 1.44.2.Refs #154