Skip to content

test: use canonical IANA timezone names (fix CI on runners without legacy tz aliases) #177

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
TexasCoding merged 1 commit into from
Oct 27, 2026
Merged

test: use canonical IANA timezone names (fix CI on runners without legacy tz aliases) #177

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion src/project_x_py/client/base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -266,7 +266,7 @@ async def from_config_file(
... "api_url": "https://api.topstepx.com/api",
... "user_hub_url": "https://rtc.topstepx.com/hubs/user",
... "market_hub_url": "https://rtc.topstepx.com/hubs/market",
... "timezone": "US/Central",
... "timezone": "America/Chicago",
... }
>>> with open("config.json", "w") as f:
... json.dump(config, f)
Expand Down
4 changes: 2 additions & 2 deletions tests/client/test_base.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -249,7 +249,7 @@ async def test_from_config_file(self):
realtime_url="wss://file.realtime.com",
user_hub_url="/file-userhub",
market_hub_url="/file-markethub",
timezone="US/Pacific",
timezone="America/Los_Angeles",
timeout_seconds=45,
retry_attempts=4,
retry_delay_seconds=1.5,
Expand Down Expand Up @@ -286,7 +286,7 @@ async def test_from_config_file_with_account_name(self):
realtime_url="wss://file.realtime.com",
user_hub_url="/file-userhub",
market_hub_url="/file-markethub",
timezone="US/Pacific",
timezone="America/Los_Angeles",
timeout_seconds=45,
retry_attempts=4,
retry_delay_seconds=1.5,
Expand Down
2 changes: 1 addition & 1 deletion tests/realtime_data_manager/test_data_access_edge_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -347,7 +347,7 @@ async def test_get_bars_since_with_pytz_timezone_object(self):
manager = MockDataAccessManager()

# Use a pytz timezone that has localize method
est = pytz.timezone("US/Eastern")
est = pytz.timezone("America/New_York")
manager.timezone = est

base_time = est.localize(datetime(2023, 6, 15, 10, 30))
Expand Down
2 changes: 1 addition & 1 deletion tests/realtime_data_manager/test_data_processing_edge_cases.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -562,7 +562,7 @@ async def test_calculate_bar_time_timezone_scenarios(self):
manager = MockDataProcessingManager()

# Test with pytz timezone (has localize method)
manager.timezone = pytz.timezone("US/Eastern")
manager.timezone = pytz.timezone("America/New_York")
naive_timestamp = datetime(2023, 6, 15, 10, 30, 45)

bar_time = manager._calculate_bar_time(naive_timestamp, 5, 2)
Expand Down
Loading