update metrics for public designs - #4419
Conversation
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
Signed-off-by: Eder Monteiro <emrmonteiro@precisioninno.com>
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
There was a problem hiding this comment.
Code Review
This pull request updates the OpenROAD submodule to a newer commit and adjusts the baseline design rules (rules-base.json) for several designs, including ibex, swerv_wrapper, gcd, and microwatt. The review feedback highlights several significant regressions introduced by this update: a 16.2% increase in detailed routing wirelength and a 16% degradation in global routing setup TNS for the swerv_wrapper design, alongside a threefold degradation in global routing setup TNS for the ibex design.
| }, | ||
| "detailedroute__route__wirelength": { | ||
| "value": 4160494, | ||
| "value": 4835341, |
There was a problem hiding this comment.
The detailed routing wirelength has increased significantly by approximately 16.2% (from 4160494 to 4835341). Since there is no corresponding improvement in area or other metrics for this design, this represents a severe routing regression introduced by the OpenROAD submodule update. Accepting this change permanently lowers the quality bar for this design in CI.
| }, | ||
| "globalroute__timing__setup__tns": { | ||
| "value": -438.0, | ||
| "value": -509.0, |
There was a problem hiding this comment.
The global routing setup TNS has degraded by over 16% (from -438.0 to -509.0). Combined with the 16.2% increase in detailed routing wirelength, this indicates a substantial degradation in physical synthesis quality for the swerv_wrapper design under the new OpenROAD commit.
| }, | ||
| "globalroute__timing__setup__tns": { | ||
| "value": -1.6, | ||
| "value": -4.99, |
There was a problem hiding this comment.
The global routing setup TNS has degraded significantly from -1.6 to -4.99 (more than a 3x increase in total negative slack). While the final timing (finish__timing__setup__tns) shows an improvement, such a large degradation at the global routing stage indicates a potential regression in the early optimization or clock tree synthesis phases of the updated OpenROAD tool.
🔍 QoR checkMetrics reflect the PR merge build — i.e. what will land on the target branch. Advisory — results are log-only and do not affect build status. The authoritative QoR gate remains the local rules-file check. Commit 61 design(s) checked — 8 with regression(s), 0 without a comparable baseline.
❌ asap7/riscv32i-mock-sram base — 1 failing metric(s)
❌ ihp-sg13g2/ibex base — 1 failing metric(s)
❌ nangate45/mempool_group base — 1 failing metric(s)
❌ nangate45/swerv base — 2 failing metric(s)
❌ nangate45/swerv_wrapper base — 3 failing metric(s)
❌ sky130hd/gcd base — 1 failing metric(s)
❌ sky130hd/microwatt base — 2 failing metric(s)
❌ sky130hs/riscv32i base — 2 failing metric(s)
|
2 participants
designs/sky130hd/microwatt/rules-base.json updates:
designs/sky130hd/gcd/rules-base.json updates:
designs/nangate45/swerv_wrapper/rules-base.json updates:
designs/ihp-sg13g2/ibex/rules-base.json updates: