feat: add magic square algorithms - #1586
Open
namanhegde018-ux wants to merge 1 commit into
Open
namanhegde018-ux wants to merge 1 commit into
namanhegde018-ux wants to merge 1 commit into
Conversation
namanhegde018-ux
requested review from
Panquesito7,
alexpantyukhin and
tjgurwara99
as code owners
September 2, 2026 15:17
Author
|
The algorithm names are intentionally kept in their original form to preserve the historical terminology and give credit to their creators.. |
Author
|
Hi @Panquesito7 @tjgurwara99 @alexpantyukhin Just dropping a friendly ping on PR #1586. All automated checks are passing, tests are included, and it implements odd, doubly-even, and singly-even magic square constructions. Whenever you have a spare moment to take a look, I'd appreciate your feedback! |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description of Change
Adds algorithms for constructing normal magic squares for odd, singly-even, and doubly-even orders.
The implementation uses:
Includes self-tests for the generated magic squares.
References
No related issue or previous pull request.
Checklist
Notes: Implements three different construction methods for normal magic squares based on the parity of the order.