Repository navigation
⚡ Bolt: [performance improvement] O(1) lookups in FileList render loop - #29
TheerasakPing wants to merge 3 commits into
Conversation
Co-authored-by: TheerasakPing <185220419+TheerasakPing@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
Co-authored-by: TheerasakPing <185220419+TheerasakPing@users.noreply.github.com>
…p, plus CI fixes Co-authored-by: TheerasakPing <185220419+TheerasakPing@users.noreply.github.com>
💡 What: Optimized
FileList.jsxto pre-computeSetobjects forselectedPathsandcutPathsusinguseMemo, instead of usingArray.some()inside thesortedItems.maploop.🎯 Why: Resolves an O(NM) rendering complexity bottleneck.
Array.some()inside the map over items meant iterating over secondary arrays (selectedItems,clipboard.items) for every item rendered. This scales poorly in directories with a large number of files.📊 Impact: Reduces rendering complexity from O(NM) to O(N) by replacing O(N) Array lookups with O(1) Set lookups. This should measurably speed up rendering for folders with hundreds or thousands of files.
🔬 Measurement: Verify rendering speed in a directory with 10,000+ files before and after this change, particularly when selecting or cutting multiple items.
PR created automatically by Jules for task 6148484550784837859 started by @TheerasakPing